linux-kernel - Re: [PATCH v2 1/8] Revert "binder: switch alloc->mutex to spinlock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZyzO-vbufELmBlvf@google.com>
Date: Thu, 7 Nov 2024 14:30:18 +0000
From: Carlos Llamas <cmllamas@...gle.com>
To: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc: Arve Hjønnevåg <arve@...roid.com>,
	Todd Kjos <tkjos@...roid.com>, Martijn Coenen <maco@...roid.com>,
	Joel Fernandes <joel@...lfernandes.org>,
	Christian Brauner <brauner@...nel.org>,
	Suren Baghdasaryan <surenb@...gle.com>,
	linux-kernel@...r.kernel.org, kernel-team@...roid.com,
	Mukesh Ojha <quic_mojha@...cinc.com>
Subject: Re: [PATCH v2 1/8] Revert "binder: switch alloc->mutex to spinlock_t"

On Thu, Nov 07, 2024 at 09:56:16AM +0100, Greg Kroah-Hartman wrote:
> On Thu, Nov 07, 2024 at 04:02:23AM +0000, Carlos Llamas wrote:
> > This reverts commit 7710e2cca32e7f3958480e8bd44f50e29d0c2509.
> > 
> > In preparation for concurrent page installations, restore the original
> > alloc->mutex which will serialize zap_page_range_single() against page
> > installations in subsequent patches (instead of the mmap_sem).
> > 
> > Cc: Mukesh Ojha <quic_mojha@...cinc.com>
> > [cmllamas: fix trivial conflict due to 2c10a20f5e84a]
> 
> Nit, commits have the full name in them as well, not just the sha1 one,
> i.e.:
> 	2c10a20f5e84 ("binder_alloc: Fix sleeping function called from invalid context")
>

Sounds good, done for v3.

Cheers,
Carlos Llamas