linux-kernel - Re: [PATCH v1 1/1] ext4: Mark ctx_*_flags() with __maybe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <173099237652.321265.10285147314842197735.b4-ty@mit.edu>
Date: Thu,  7 Nov 2024 10:12:54 -0500
From: "Theodore Ts'o" <tytso@....edu>
To: linux-ext4@...r.kernel.org, linux-kernel@...r.kernel.org,
        llvm@...ts.linux.dev,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc: "Theodore Ts'o" <tytso@....edu>, Andreas Dilger <adilger.kernel@...ger.ca>,
        Nathan Chancellor <nathan@...nel.org>,
        Nick Desaulniers <ndesaulniers@...gle.com>,
        Bill Wendling <morbo@...gle.com>,
        Justin Stitt <justinstitt@...gle.com>
Subject: Re: [PATCH v1 1/1] ext4: Mark ctx_*_flags() with __maybe_unused


On Thu, 05 Sep 2024 19:32:29 +0300, Andy Shevchenko wrote:
> When ctx_set_flags() is unused, it prevents kernel builds
> with clang, `make W=1` and CONFIG_WERROR=y:
> 
> .../ext4/super.c:2120:1: error: unused function 'ctx_set_flags' [-Werror,-Wunused-function]
>  2120 | EXT4_SET_CTX(flags); /* set only */
>       | ^~~~~~~~~~~~~~~~~~~
> 
> [...]

Applied, thanks!

[1/1] ext4: Mark ctx_*_flags() with __maybe_unused
      commit: 7bdb90e0f6c832c00a4c0a5d841aa367502dbfef

Best regards,
-- 
Theodore Ts'o <tytso@....edu>