linux-kernel - Re: [PATCH] uprobes: get RCU trace lock before list iteration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAEf4BzaktmbL0T4a1i-hR4SCYYDSNUO1AWAY4UujefecyMUz8g@mail.gmail.com>
Date: Thu, 7 Nov 2024 10:14:49 -0800
From: Andrii Nakryiko <andrii.nakryiko@...il.com>
To: Breno Leitao <leitao@...ian.org>
Cc: Masami Hiramatsu <mhiramat@...nel.org>, Oleg Nesterov <oleg@...hat.com>, 
	Peter Zijlstra <peterz@...radead.org>, Ingo Molnar <mingo@...hat.com>, 
	Arnaldo Carvalho de Melo <acme@...nel.org>, Namhyung Kim <namhyung@...nel.org>, 
	Mark Rutland <mark.rutland@....com>, 
	Alexander Shishkin <alexander.shishkin@...ux.intel.com>, Jiri Olsa <jolsa@...nel.org>, 
	Ian Rogers <irogers@...gle.com>, Adrian Hunter <adrian.hunter@...el.com>, 
	Andrii Nakryiko <andrii@...nel.org>, linux-perf-users@...r.kernel.org, 
	linux-kernel@...r.kernel.org, linux-trace-kernel@...r.kernel.org, 
	kernel-team@...a.com
Subject: Re: [PATCH] uprobes: get RCU trace lock before list iteration

On Thu, Nov 7, 2024 at 9:16 AM Breno Leitao <leitao@...ian.org> wrote:
>
> Acquire RCU trace lock in filter_chain() to protect
> list_for_each_entry_rcu() iteration, protecting the list iteration in a
> RCU read section.
>
> Prior to this fix, list_for_each_entry_srcu() was called without holding
> the required lock, triggering warnings when RCU_PROVING is enabled:
>
>         kernel/events/uprobes.c:937 RCU-list traversed without holding the required lock!!
>
> Signed-off-by: Breno Leitao <leitao@...ian.org>
> Fixes: cc01bd044e6a ("uprobes: travers uprobe's consumer list locklessly under SRCU protection")
> ---
>  kernel/events/uprobes.c | 2 ++
>  1 file changed, 2 insertions(+)

LGTM, thanks

Reviewed-by: Andrii Nakryiko <andrii@...nel.org>

>
> diff --git a/kernel/events/uprobes.c b/kernel/events/uprobes.c
> index fa04b14a7d72353adc440742016b813da6c812d2..afdaa45a43ac3948f7983175eda808c989e8738a 100644
> --- a/kernel/events/uprobes.c
> +++ b/kernel/events/uprobes.c
> @@ -1103,11 +1103,13 @@ static bool filter_chain(struct uprobe *uprobe, struct mm_struct *mm)
>         bool ret = false;
>
>         down_read(&uprobe->consumer_rwsem);
> +       rcu_read_lock_trace();
>         list_for_each_entry_rcu(uc, &uprobe->consumers, cons_node, rcu_read_lock_trace_held()) {
>                 ret = consumer_filter(uc, mm);
>                 if (ret)
>                         break;
>         }
> +       rcu_read_unlock_trace();
>         up_read(&uprobe->consumer_rwsem);
>
>         return ret;
>
> ---
> base-commit: 5b913f5d7d7fe0f567dea8605f21da6eaa1735fb
> change-id: 20241107-rcu_probe-bef660d84990
>
> Best regards,
> --
> Breno Leitao <leitao@...ian.org>
>