linux-kernel - Re: [PATCH net v4] net: ti: icssg-prueth: Fix 1 PPS sync

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20241107111542.19dc55e2@kernel.org>
Date: Thu, 7 Nov 2024 11:15:42 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Meghana Malladi <m-malladi@...com>
Cc: <vigneshr@...com>, <horms@...nel.org>, <jan.kiszka@...mens.com>,
 <diogo.ivo@...mens.com>, <pabeni@...hat.com>, <edumazet@...gle.com>,
 <davem@...emloft.net>, <andrew+netdev@...n.ch>,
 <linux-kernel@...r.kernel.org>, <netdev@...r.kernel.org>,
 <linux-arm-kernel@...ts.infradead.org>, <srk@...com>, Roger Quadros
 <rogerq@...nel.org>, <danishanwar@...com>
Subject: Re: [PATCH net v4] net: ti: icssg-prueth: Fix 1 PPS sync

On Wed, 6 Nov 2024 12:53:14 +0530 Meghana Malladi wrote:
> +static inline __u64 icssg_readq(const void __iomem *addr)

two nit picks:
 - since the function is now fairly special purpose I think a name less
   generic than readq would be appropriate. Maybe icssg_read_time() ?
 - __u64 is for uAPI, to avoid type name conflicts, in the kernel
   please use u64 without the underscores
-- 
pw-bot: cr