[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <79f0ce60-58a5-4757-88eb-1cdc8a80388b@amd.com>
Date: Thu, 7 Nov 2024 11:31:50 -0800
From: "Nelson, Shannon" <shannon.nelson@....com>
To: Wentao Liang <liangwentao@...as.ac.cn>, brett.creeley@....com,
davem@...emloft.net, kuba@...nel.org
Cc: linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
Wentao Liang <Wentao_liang_g@....com>
Subject: Re: [PATCH net v3] drivers: net: ionic: add missed debugfs cleanup to
ionic_probe() error path
On 11/6/2024 6:17 PM, Wentao Liang wrote:
>
> From: Wentao Liang <Wentao_liang_g@....com>
>
> The ionic_setup_one() creates a debugfs entry for ionic upon
> successful execution. However, the ionic_probe() does not
> release the dentry before returning, resulting in a memory
> leak.
>
> To fix this bug, we add the ionic_debugfs_del_dev() to release
> the resources in a timely manner before returning.
>
> Fixes: 0de38d9f1dba ("ionic: extract common bits from ionic_probe")
> Signed-off-by: Wentao Liang <Wentao_liang_g@....com>
Thanks! -sln
Acked-by: Shannon Nelson <shannon.nelson@....com>
> ---
> drivers/net/ethernet/pensando/ionic/ionic_bus_pci.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/ethernet/pensando/ionic/ionic_bus_pci.c b/drivers/net/ethernet/pensando/ionic/ionic_bus_pci.c
> index b93791d6b593..f5dc876eb500 100644
> --- a/drivers/net/ethernet/pensando/ionic/ionic_bus_pci.c
> +++ b/drivers/net/ethernet/pensando/ionic/ionic_bus_pci.c
> @@ -394,6 +394,7 @@ static int ionic_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
> err_out_pci:
> ionic_dev_teardown(ionic);
> ionic_clear_pci(ionic);
> + ionic_debugfs_del_dev(ionic);
> err_out:
> mutex_destroy(&ionic->dev_cmd_lock);
> ionic_devlink_free(ionic);
> --
> 2.42.0.windows.2
>
Powered by blists - more mailing lists