[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <75495b79-65fb-4a70-a937-36f969280ce6@lunn.ch>
Date: Thu, 7 Nov 2024 20:36:35 +0100
From: Andrew Lunn <andrew@...n.ch>
To: Christophe JAILLET <christophe.jaillet@...adoo.fr>
Cc: Christian Marangi <ansuelsmth@...il.com>,
Florian Fainelli <f.fainelli@...il.com>,
Vladimir Oltean <olteanv@...il.com>,
"David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>,
Conor Dooley <conor+dt@...nel.org>,
Heiner Kallweit <hkallweit1@...il.com>,
Russell King <linux@...linux.org.uk>,
Matthias Brugger <matthias.bgg@...il.com>,
"AngeloGioacchino Del Regno," <angelogioacchino.delregno@...labora.com>,
linux-arm-kernel@...ts.infradead.org,
linux-mediatek@...ts.infradead.org, netdev@...r.kernel.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
upstream@...oha.com
Subject: Re: [net-next PATCH v3 2/3] net: dsa: Add Airoha AN8855 5-Port
Gigabit DSA Switch driver
> > +enum an8855_stp_state {
> > + AN8855_STP_DISABLED = 0,
> > + AN8855_STP_BLOCKING = 1,
> > + AN8855_STP_LISTENING = 1,
>
> Just wondering if this 0, 1, *1*, 2, 3 was intentional?
There are some devices which don't differentiate between blocking and
listening. If this is true, then maybe:
+enum an8855_stp_state {
+ AN8855_STP_DISABLED = 0,
+ AN8855_STP_BLOCKING = 1,
+ AN8855_STP_LISTENING = AN8855_STP_BLOCKING,
Which saves a comment.
Andrew
Powered by blists - more mailing lists