linux-kernel - Re: [PATCH] PCI: mvebu: Use for_each_of_range() iterator for parsing "ranges"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAL_JsqJ-BaHq+o+E-OtAf8YbJbNnPSKHjvgAn_oq8KVEKPq4rg@mail.gmail.com>
Date: Thu, 7 Nov 2024 15:19:20 -0600
From: Rob Herring <robh@...nel.org>
To: Pali Rohár <pali@...nel.org>
Cc: Thomas Petazzoni <thomas.petazzoni@...tlin.com>, Lorenzo Pieralisi <lpieralisi@...nel.org>, 
	Krzysztof Wilczyński <kw@...ux.com>, 
	Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>, Bjorn Helgaas <bhelgaas@...gle.com>, 
	linux-pci@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] PCI: mvebu: Use for_each_of_range() iterator for parsing "ranges"

On Thu, Nov 7, 2024 at 11:00 AM Pali Rohár <pali@...nel.org> wrote:
>
> On Thursday 07 November 2024 09:32:55 Rob Herring (Arm) wrote:
> > The mvebu "ranges" is a bit unusual with its own encoding of addresses,
> > but it's still just normal "ranges" as far as parsing is concerned.
> > Convert mvebu_get_tgt_attr() to use the for_each_of_range() iterator
> > instead of open coding the parsing.
> >
> > Signed-off-by: Rob Herring (Arm) <robh@...nel.org>
> > ---
> > Compile tested only.
>
> I see no reason for such change, which was even non tested at all and
> does not fix any issue.

Maintenance of the kernel is an issue. Maybe not for you, but for some of us.

>  There are more important issues in the driver,
> it was decided that bug fixes are not going to be included (yet).

The larger reason is to get rid of custom parsing of address
properties throughout the kernel. As well as remove and consolidate
uses of_n_addr_cells() and remove its support of long since deprecated
behavior. Also, I intend to make of_get_property/of_find_property()
warn about leaking data since it just returns a pointer into the raw
DT data and we have no control over the lifetime. Then we can't free
those properties. Why do we care? Overlays and Rust.

Rob