linux-kernel - Re: [PATCH net-next] eth: fbnic: Add PCIe hardware statistics

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAG4C-Om7ad+gnaFxJN0p-1YF=B-98z71Naw2ss5-Qmz85kSMpw@mail.gmail.com>
Date: Wed, 6 Nov 2024 18:16:09 -0800
From: Sanman Pradhan <sanman.p211993@...il.com>
To: Andrew Lunn <andrew@...n.ch>
Cc: netdev@...r.kernel.org, alexanderduyck@...com, kuba@...nel.org, 
	kernel-team@...a.com, davem@...emloft.net, edumazet@...gle.com, 
	pabeni@...hat.com, horms@...nel.org, corbet@....net, mohsin.bashr@...il.com, 
	sanmanpradhan@...a.com, andrew+netdev@...n.ch, vadim.fedorenko@...ux.dev, 
	jdamato@...tly.com, sdf@...ichev.me, linux-doc@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next] eth: fbnic: Add PCIe hardware statistics

On Wed, 6 Nov 2024 at 09:32, Andrew Lunn <andrew@...n.ch> wrote:
>
> > +struct fbnic_hw_stat {
> > +     struct fbnic_stat_counter frames;
> > +     struct fbnic_stat_counter bytes;
> > +};
>
> I don't think this belongs in this patch, since the PCIe counters
> don't seem to have anything to do with frames or bytes.
>
>         Andrew

Removed the unnecessary block in v2.

Thanks for reviewing the patch, Andrew