linux-kernel - Re: [PATCH] rust: bindings: Support some inline static functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAKmqyKPv9DrvisrLOWX=i2qqKbRbNz40__FSGm6piC_0y94m_g@mail.gmail.com>
Date: Thu, 7 Nov 2024 12:26:43 +1000
From: Alistair Francis <alistair23@...il.com>
To: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
Cc: linux-kernel@...r.kernel.org, rust-for-linux@...r.kernel.org, 
	ojeda@...nel.org, boqun.feng@...il.com, a.hindborg@...nel.org, 
	benno.lossin@...ton.me, aliceryhl@...gle.com, tmgross@...ch.edu, 
	gary@...yguo.net, Alistair Francis <alistair.francis@....com>
Subject: Re: [PATCH] rust: bindings: Support some inline static functions

On Tue, Nov 5, 2024 at 7:32 PM Miguel Ojeda
<miguel.ojeda.sandonis@...il.com> wrote:
>
> On Tue, Nov 5, 2024 at 3:22 AM Alistair Francis <alistair23@...il.com> wrote:
> >
> > If this is accepted or at least Acked I can work on removing the
> > existing rust_helper_* functions and convert them to be auto-generated.
>
> Yeah, we have tracked the feature for a long time, please see:
>
>     https://github.com/Rust-for-Linux/linux/issues/353
>
> So it is definitely in our plan to use (assuming it works).
>
> But, yeah, we would need the patch with the conversions, to show how
> it would look in practice (i.e. comparing before/after etc.), i.e. the
> usual kernel rule.

Great! I have done the conversions in a patch series here:
https://lore.kernel.org/lkml/20241107020831.1561063-1-alistair.francis@wdc.com/T/#t

>
> > +       --allowlist-function crypto_shash_descsize
>
> We probably should put this into something similar to
> `rust/bindgen_parameters` (and remove this variable).

Fixed in https://lore.kernel.org/lkml/20241107020831.1561063-1-alistair.francis@wdc.com/T/#t

>
> > +       @cp /tmp/bindgen/extern.c $(src)/
>
> I don't think we can use/assume `/tmp` -- we will need
> `--wrap-static-fns-path` or similar.

Fixed in https://lore.kernel.org/lkml/20241107020831.1561063-1-alistair.francis@wdc.com/T/#t

Alistair

>
> Thanks for trying out the new feature!
>
> Cheers,
> Miguel