linux-kernel - Re: [PATCH v3 1/2] sparc/build: Put usage of -fcall-used* flags behind cc-option

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <rYw6ZTCE58uNrfyK1pJXSaAnn3kXRYBiLf-TYQI8tnJSU3ECWG01RkUahjZC_rkJomCiROTUUvg6Jf1u5VfyBfIalrSF2jHtGqI94MGK8zg=@protonmail.com>
Date: Thu, 07 Nov 2024 04:59:14 +0000
From: Koakuma <koachan@...tonmail.com>
To: Nathan Chancellor <nathan@...nel.org>
Cc: "David S. Miller" <davem@...emloft.net>, Andreas Larsson <andreas@...sler.com>, Nick Desaulniers <ndesaulniers@...gle.com>, Bill Wendling <morbo@...gle.com>, Justin Stitt <justinstitt@...gle.com>, glaubitz@...sik.fu-berlin.de, Masahiro Yamada <masahiroy@...nel.org>, Nicolas Schier <nicolas@...sle.eu>, Jonathan Corbet <corbet@....net>, sparclinux@...r.kernel.org, linux-kernel@...r.kernel.org, llvm@...ts.linux.dev, linux-kbuild@...r.kernel.org, linux-doc@...r.kernel.org
Subject: Re: [PATCH v3 1/2] sparc/build: Put usage of -fcall-used* flags behind cc-option

Nathan Chancellor <nathan@...nel.org> wrote:
> 
> Clang builds now succeed with this series and builds with GCC 14.2.0
> continue to pass and boot successfully.
> 
> Reviewed-by: Nathan Chancellor nathan@...nel.org
> 
> Tested-by: Nathan Chancellor nathan@...nel.org
> 
> One comment below, please carry these tags forward if there are future
> revisions without substantial technical changes.

Forgive me for still being unfamiliar with the term, but does this mean that
when I send a v4 I should paste the Reviewed-by and Tested-by lines into the
commit message of the patch?

> > -KBUILD_CFLAGS += -m32 -mcpu=v8 -pipe -mno-fpu -fcall-used-g5 -fcall-used-g7
> > +KBUILD_CFLAGS += -m32 -mcpu=v8 -pipe -mno-fpu $(call cc-option,-fcall-used-g5) $(call cc-option,-fcall-used-g7)
> 
> 
> Small nit, this (and the one in the vdso) could probably be one
> cc-option call? Is it likely that one flag would be implemented in the
> compiler without the other?
> 
> $(call cc-option,-fcall-used-g5 -fcall-used-g7)

Ah, didn't know it's possible to do that, the other uses of it I see seem
to use one flag per call. I'll test and send a new revision, thanks.