linux-kernel - Re: [PATCH] usb: gadget: f_fs: remove unused values and add immediate returns

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2024110719-kennel-tiptoeing-3409@gregkh>
Date: Thu, 7 Nov 2024 06:15:36 +0100
From: Greg KH <gregkh@...uxfoundation.org>
To: Karol Przybylski <karprzy7@...il.com>
Cc: paul@...pouillou.net, tudor.ambarus@...aro.org, Chris.Wulff@...mp.com,
	david.sands@...mp.com, viro@...iv.linux.org.uk,
	m.grzeschik@...gutronix.de, peter@...sgaard.com,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
	skhan@...uxfoundation.org
Subject: Re: [PATCH] usb: gadget: f_fs: remove unused values and add
 immediate returns

On Wed, Nov 06, 2024 at 07:30:32PM +0100, Karol Przybylski wrote:
> In case of faulty copy_from_user call inside ffs_epfile_ioctl, error code is
> saved in a variable. However, this variable is later overwritten in every possible
> path, which overshadows initial assignment.
> 
> This patch fixes it by returning the error code immediately and exiting the function.
> 
> Error discovered in coverity scan - CID 1583682
> 
> Signed-off-by: Karol Przybylski <karprzy7@...il.com>
> ---
>  drivers/usb/gadget/function/f_fs.c | 9 +++------
>  1 file changed, 3 insertions(+), 6 deletions(-)

What commit id does this fix?

How was this change tested?

thanks,

greg k-h