linux-kernel - Re: [PATCH] block: Replace sprintf() with sysfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20241107054420.GA2336@lst.de>
Date: Thu, 7 Nov 2024 06:44:20 +0100
From: Christoph Hellwig <hch@....de>
To: zhangguopeng <zhangguopeng@...inos.cn>
Cc: axboe@...nel.dk, linux-block@...r.kernel.org, hch@....de,
	ming.lei@...hat.com, yukuai3@...wei.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] block: Replace sprintf() with sysfs_emit()

On Wed, Nov 06, 2024 at 04:34:54PM +0800, zhangguopeng wrote:
> -	return sprintf(page, "%llu\n",					\
> +	return sysfs_emit(page, "%llu\n",					\

Please keep the \ aligned for all the multi-line macros.

Otherwise this looks fine to me.