linux-kernel - Re: [PATCH] tty: synclink_gt: Fix incorrect formatted output

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2024110730-outfield-gigolo-e388@gregkh>
Date: Thu, 7 Nov 2024 09:44:35 +0100
From: Greg KH <gregkh@...uxfoundation.org>
To: liujing <liujing@...s.chinamobile.com>
Cc: linux-kernel@...r.kernel.org, linux-serial@...r.kernel.org
Subject: Re: [PATCH] tty: synclink_gt: Fix incorrect formatted output

On Thu, Nov 07, 2024 at 11:29:36AM +0800, liujing wrote:
> In the struct slgt_info structure, the type of info->tbuf_current
> is unsigned int, so the output format is %u.
> 
> Signed-off-by: liujing <liujing@...s.chinamobile.com>
> 
> diff --git a/drivers/tty/synclink_gt.c b/drivers/tty/synclink_gt.c
> index bd8d92ee7c53..0c51c6c28080 100644
> --- a/drivers/tty/synclink_gt.c
> +++ b/drivers/tty/synclink_gt.c
> @@ -519,7 +519,7 @@ static void trace_block(struct slgt_info *info, const char *data, int count, con
>  static void dump_tbufs(struct slgt_info *info)
>  {
>  	int i;
> -	printk("tbuf_current=%d\n", info->tbuf_current);
> +	printk("tbuf_current=%u\n", info->tbuf_current);

How was this found?  How was it tested?  Why is this code still in here
at all?  It all should be removed and if really needed, converted to use
the proper in-kernel apis for this type of thing, not a random module
parameter that does not fit in with the rest of the kernel.

thanks,

greg k-h