[<prev] [next>] [day] [month] [year] [list]
Message-ID: <99fa8255-12b5-4a54-acfe-cc0fbbba9c0e@gmail.com>
Date: Thu, 7 Nov 2024 18:36:26 +0800
From: Joey Lu <a0987203069@...il.com>
To: Andrew Lunn <andrew@...n.ch>
Cc: andrew+netdev@...n.ch, davem@...emloft.net, edumazet@...gle.com,
kuba@...nel.org, pabeni@...hat.com, robh@...nel.org, krzk+dt@...nel.org,
conor+dt@...nel.org, mcoquelin.stm32@...il.com, richardcochran@...il.com,
alexandre.torgue@...s.st.com, joabreu@...opsys.com, ychuang3@...oton.com,
schung@...oton.com, yclu4@...oton.com, linux-arm-kernel@...ts.infradead.org,
netdev@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org, openbmc@...ts.ozlabs.org,
linux-stm32@...md-mailman.stormreply.com
Subject: Re: [PATCH 3/3] net: stmmac: dwmac-nuvoton: Add dwmac glue for
Nuvoton MA35 family
Dear Andrew,
Thank you for your reply.
Andrew Lunn 於 11/7/2024 2:23 AM 寫道:
>> +struct nvt_priv_data {
>> + struct platform_device *pdev;
>> + int id;
>> + struct regmap *regmap;
>> + phy_interface_t phy_mode;
> phy_mode does not seem to be used outside of nuvoton_gmac_setup(). In
> fact nothing in nvt_priv_data is used outside of
> nuvoton_gmac_setup. So it looks like you can remove it.
I will remove it.
>> + if (of_property_read_u32(dev->of_node, "tx_delay", &tx_delay)) {
>> + dev_info(dev, "Set TX delay(0x0).\n");
>> + tx_delay = 0x0;
>> + } else {
>> + dev_info(dev, "Set TX delay(0x%x).\n", tx_delay);
> Please don't spam the logs. dev_dbg(), or no message at all.
>
> Andrew
I will fix it.
Thanks!
BR,
Joey
Powered by blists - more mailing lists