linux-kernel - Re: [PATCH 1/2] dt-bindings: soc: ti: pruss: Add clocks for ICSSG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7f0a73c3-9977-4d07-b996-683ed18e4724@kernel.org>
Date: Thu, 7 Nov 2024 12:31:40 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: MD Danish Anwar <danishanwar@...com>, conor+dt@...nel.org,
 krzk+dt@...nel.org, robh@...nel.org, ssantosh@...nel.org, nm@...com,
 Vignesh Raghavendra <vigneshr@...com>
Cc: devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 linux-kernel@...r.kernel.org, s-anna@...com, kristo@...nel.org, srk@...com,
 Roger Quadros <rogerq@...nel.org>
Subject: Re: [PATCH 1/2] dt-bindings: soc: ti: pruss: Add clocks for ICSSG

On 07/11/2024 11:45, MD Danish Anwar wrote:
> Add clocks, assigned-clocks and assigned-clock-parents for ICSSG

Why? We see what you are doing from the diff, no point to repeat it. I
don't understand why you are doing it.

> 
> Signed-off-by: MD Danish Anwar <danishanwar@...com>
> ---
>  .../devicetree/bindings/soc/ti/ti,pruss.yaml          | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml b/Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml
> index 3cb1471cc6b6..cf4c5884d8be 100644
> --- a/Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml
> +++ b/Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml
> @@ -92,6 +92,17 @@ properties:
>      description: |
>        This property is as per sci-pm-domain.txt.
>  
> +  clocks:
> +    items:
> +      - description: ICSSG_CORE Clock
> +      - description: ICSSG_ICLK Clock
> +
> +  assigned-clocks:
> +    maxItems: 1
> +
> +  assigned-clock-parents:
> +    maxItems: 1

Why? This is really not needed, so you need to explain why you are doing
things differently than entire Linux kernel / DT bindings.

Best regards,
Krzysztof