| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <2e7a1eb6-df8f-44d4-9342-1bc6d8b5ad11@ti.com>
Date: Thu, 7 Nov 2024 17:28:38 +0530
From: MD Danish Anwar <danishanwar@...com>
To: Krzysztof Kozlowski <krzk@...nel.org>, <conor+dt@...nel.org>,
<krzk+dt@...nel.org>, <robh@...nel.org>, <ssantosh@...nel.org>,
<nm@...com>, Vignesh Raghavendra <vigneshr@...com>
CC: <devicetree@...r.kernel.org>, <linux-arm-kernel@...ts.infradead.org>,
<linux-kernel@...r.kernel.org>, <s-anna@...com>, <kristo@...nel.org>,
<srk@...com>, Roger Quadros <rogerq@...nel.org>
Subject: Re: [PATCH 1/2] dt-bindings: soc: ti: pruss: Add clocks for ICSSG
On 07/11/24 5:16 pm, MD Danish Anwar wrote:
>
>
> On 07/11/24 5:14 pm, Krzysztof Kozlowski wrote:
>> On 07/11/2024 12:36, MD Danish Anwar wrote:
>>>
>>>
>>> On 07/11/24 5:01 pm, Krzysztof Kozlowski wrote:
>>>> On 07/11/2024 11:45, MD Danish Anwar wrote:
>>>>> Add clocks, assigned-clocks and assigned-clock-parents for ICSSG
>>>>
>>>> Why? We see what you are doing from the diff, no point to repeat it. I
>>>> don't understand why you are doing it.
>>>>
>>>>>
>>>>> Signed-off-by: MD Danish Anwar <danishanwar@...com>
>>>>> ---
>>>>> .../devicetree/bindings/soc/ti/ti,pruss.yaml | 11 +++++++++++
>>>>> 1 file changed, 11 insertions(+)
>>>>>
>>>>> diff --git a/Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml b/Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml
>>>>> index 3cb1471cc6b6..cf4c5884d8be 100644
>>>>> --- a/Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml
>>>>> +++ b/Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml
>>>>> @@ -92,6 +92,17 @@ properties:
>>>>> description: |
>>>>> This property is as per sci-pm-domain.txt.
>>>>>
>>>>> + clocks:
>>>>> + items:
>>>>> + - description: ICSSG_CORE Clock
>>>>> + - description: ICSSG_ICLK Clock
>>>>> +
>>>>> + assigned-clocks:
>>>>> + maxItems: 1
>>>>> +
>>>>> + assigned-clock-parents:
>>>>> + maxItems: 1
>>>>
>>>> Why? This is really not needed, so you need to explain why you are doing
>>>> things differently than entire Linux kernel / DT bindings.
>>>>
>>>
>>> I need to add this to the device tree node
>>>
>>> + clocks = <&k3_clks 81 0>, /* icssg0_core_clk */
>>> + <&k3_clks 81 20>; /* icssg0_iclk */
>>> + assigned-clocks = <&k3_clks 81 0>;
>>> + assigned-clock-parents = <&k3_clks 81 2>;
>>>
>>> But without the above change in the binding I am getting below errors
>>> while running dtbs check.
>>>
>>> /workdir/arch/arm64/boot/dts/ti/k3-am642-evm-nand.dtb: icssg@...00000:
>>> 'assigned-clock-parents', 'assigned-clocks' do not match any of the
>>> regexes: '^(pru|rtu|txpru)@[0-9a-f]+$', '^pa-stats@[a-f0-9]+$',
>>> 'cfg@[a-f0-9]+$', 'iep@[a-f0-9]+$', 'interrupt-controller@[a-f0-9]+$',
>>> 'mdio@[a-f0-9]+$', 'memories@[a-f0-9]+$', 'mii-g-rt@[a-f0-9]+$',
>>> 'mii-rt@[a-f0-9]+$', 'pinctrl-[0-9]+'
>>> +/workdir/arch/arm64/boot/dts/ti/k3-am642-evm-nand.dtb: icssg@...80000:
>>> 'anyOf' conditional failed, one must be fixed:
>>>
>>> To fix this warning I added these in the binding and the warnings were
>>> fixed.
>>
>> nah, cannot reproduce. Just be sure you work on recent kernel (last time
>> you were sending it on some ancient stuff) and your packages are
>> updated, including dt schema and other kernel dependencies.
>>
>
> I have posted this series on the latest kernel. Base commit
> 5b913f5d7d7fe0f567dea8605f21da6eaa1735fb
>
> Let me check if the schema is up to date or not. I will re test and
> reply. Thanks for pointing it out.
>
Krzysztof, I re-checked.
I am on the latest kernel (commit
5b913f5d7d7fe0f567dea8605f21da6eaa1735fb (tag: next-20241106,
origin/master, origin/HEAD)) and I am using the lastest dtschema v2024.9
❯ python3 -m pip list|grep 'dtschema'
dtschema 2024.9
Still I am getting the below dtbs check errors while running `make
CHECK_DTBS=y ti/k3-am642-evm.dtb` without the binding change.
Let me know if I am missing something else.
/home/danish/workspace/linux-next/arch/arm64/boot/dts/ti/k3-am642-evm.dtb:
icssg@...00000: 'assigned-clock-parents', 'assigned-clocks', 'clocks' do
not match any of the regexes: '^(pru|rtu|txpru)@[0-9a-f]+$',
'^pa-stats@[a-f0-9]+$', 'cfg@[a-f0-9]+$', 'iep@[a-f0-9]+$',
'interrupt-controller@[a-f0-9]+$', 'mdio@[a-f0-9]+$',
'memories@[a-f0-9]+$', 'mii-g-rt@[a-f0-9]+$', 'mii-rt@[a-f0-9]+$',
'pinctrl-[0-9]+'
from schema $id: http://devicetree.org/schemas/soc/ti/ti,pruss.yaml#
/home/danish/workspace/linux-next/arch/arm64/boot/dts/ti/k3-am642-evm.dtb:
icssg@...00000: 'assigned-clock-parents', 'assigned-clocks', 'clocks' do
not match any of the regexes: '^(pru|rtu|txpru)@[0-9a-f]+$',
'^pa-stats@[a-f0-9]+$', 'cfg@[a-f0-9]+$', 'iep@[a-f0-9]+$',
'interrupt-controller@[a-f0-9]+$', 'mdio@[a-f0-9]+$',
'memories@[a-f0-9]+$', 'mii-g-rt@[a-f0-9]+$', 'mii-rt@[a-f0-9]+$',
'pinctrl-[0-9]+'
from schema $id: http://devicetree.org/schemas/soc/ti/ti,pruss.yaml#
/home/danish/workspace/linux-next/arch/arm64/boot/dts/ti/k3-am642-evm.dtb:
icssg@...80000: 'assigned-clock-parents', 'assigned-clocks', 'clocks' do
not match any of the regexes: '^(pru|rtu|txpru)@[0-9a-f]+$',
'^pa-stats@[a-f0-9]+$', 'cfg@[a-f0-9]+$', 'iep@[a-f0-9]+$',
'interrupt-controller@[a-f0-9]+$', 'mdio@[a-f0-9]+$',
'memories@[a-f0-9]+$', 'mii-g-rt@[a-f0-9]+$', 'mii-rt@[a-f0-9]+$',
'pinctrl-[0-9]+'
from schema $id: http://devicetree.org/schemas/soc/ti/ti,pruss.yaml#
/home/danish/workspace/linux-next/arch/arm64/boot/dts/ti/k3-am642-evm.dtb:
icssg@...80000: 'assigned-clock-parents', 'assigned-clocks', 'clocks' do
not match any of the regexes: '^(pru|rtu|txpru)@[0-9a-f]+$',
'^pa-stats@[a-f0-9]+$', 'cfg@[a-f0-9]+$', 'iep@[a-f0-9]+$',
'interrupt-controller@[a-f0-9]+$', 'mdio@[a-f0-9]+$',
'memories@[a-f0-9]+$', 'mii-g-rt@[a-f0-9]+$', 'mii-rt@[a-f0-9]+$',
'pinctrl-[0-9]+'
from schema $id: http://devicetree.org/schemas/soc/ti/ti,pruss.yaml#
>
>
>> Best regards,
>> Krzysztof
>>
>
--
Thanks and Regards,
Danish
Powered by blists - more mailing lists