[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAPY8ntBK6r-_mbbt+QG+rVV4oN9bAt+YJ7jr-77vTrECAbQ32g@mail.gmail.com>
Date: Thu, 7 Nov 2024 12:31:57 +0000
From: Dave Stevenson <dave.stevenson@...pberrypi.com>
To: Jai Luthra <jai.luthra@...asonboard.com>
Cc: Sakari Ailus <sakari.ailus@...ux.intel.com>,
Mauro Carvalho Chehab <mchehab@...nel.org>, linux-media@...r.kernel.org,
linux-kernel@...r.kernel.org, David Plowman <david.plowman@...pberrypi.com>
Subject: Re: [PATCH 1/3] media: i2c: imx219: Correct the minimum vblanking value
On Tue, 29 Oct 2024 at 08:58, Jai Luthra <jai.luthra@...asonboard.com> wrote:
>
> From: David Plowman <david.plowman@...pberrypi.com>
>
> The datasheet for this sensor documents the minimum vblanking as being
> 32 lines. It does fix some problems with occasional black lines at the
> bottom of images (tested on Raspberry Pi).
>
> Signed-off-by: David Plowman <david.plowman@...pberrypi.com>
> Signed-off-by: Jai Luthra <jai.luthra@...asonboard.com>
Reviewed-by: Dave Stevenson <dave.stevenson@...pberrypi.com>
> ---
> drivers/media/i2c/imx219.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/i2c/imx219.c b/drivers/media/i2c/imx219.c
> index e78a80b2bb2e455c857390b188c128b28c224778..f98aad74fe584a18e2fe7126f92bf294762a54e3 100644
> --- a/drivers/media/i2c/imx219.c
> +++ b/drivers/media/i2c/imx219.c
> @@ -74,7 +74,7 @@
> #define IMX219_REG_VTS CCI_REG16(0x0160)
> #define IMX219_VTS_MAX 0xffff
>
> -#define IMX219_VBLANK_MIN 4
> +#define IMX219_VBLANK_MIN 32
>
> /* HBLANK control - read only */
> #define IMX219_PPL_DEFAULT 3448
>
> --
> 2.47.0
>
Powered by blists - more mailing lists