[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20241107132846.1118835-5-srasheed@marvell.com>
Date: Thu, 7 Nov 2024 05:28:43 -0800
From: Shinas Rasheed <srasheed@...vell.com>
To: <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>
CC: <hgani@...vell.com>, <sedara@...vell.com>, <vimleshk@...vell.com>,
<thaller@...hat.com>, <wizhao@...hat.com>, <kheib@...hat.com>,
<egallen@...hat.com>, <konguyen@...hat.com>, <horms@...nel.org>,
<frank.feng@...axg.com>, Shinas Rasheed <srasheed@...vell.com>,
Veerasenareddy Burru <vburru@...vell.com>,
Andrew Lunn
<andrew+netdev@...n.ch>,
"David S. Miller" <davem@...emloft.net>,
"Eric
Dumazet" <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>, Paolo Abeni
<pabeni@...hat.com>
Subject: [PATCH net v2 4/7] octeon_ep: add protective null checks in napi callbacks for cnxk cards
During unload, at times the OQ parsed in the napi callbacks
have been observed to be null, causing system crash.
Add protective checks to avoid the same, for cnxk cards.
Signed-off-by: Shinas Rasheed <srasheed@...vell.com>
---
V2:
- Split into a separate patch
- Added more context
V1: https://lore.kernel.org/all/20241101103416.1064930-3-srasheed@marvell.com/
drivers/net/ethernet/marvell/octeon_ep/octep_cnxk_pf.c | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/marvell/octeon_ep/octep_cnxk_pf.c b/drivers/net/ethernet/marvell/octeon_ep/octep_cnxk_pf.c
index 5de0b5ecbc5f..65a8dc1d492b 100644
--- a/drivers/net/ethernet/marvell/octeon_ep/octep_cnxk_pf.c
+++ b/drivers/net/ethernet/marvell/octeon_ep/octep_cnxk_pf.c
@@ -638,7 +638,14 @@ static irqreturn_t octep_rsvd_intr_handler_cnxk_pf(void *dev)
static irqreturn_t octep_ioq_intr_handler_cnxk_pf(void *data)
{
struct octep_ioq_vector *vector = (struct octep_ioq_vector *)data;
- struct octep_oq *oq = vector->oq;
+ struct octep_oq *oq;
+
+ if (!vector)
+ return IRQ_HANDLED;
+ oq = vector->oq;
+
+ if (!oq || !(oq->napi))
+ return IRQ_HANDLED;
napi_schedule_irqoff(oq->napi);
return IRQ_HANDLED;
--
2.25.1
Powered by blists - more mailing lists