[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <20241108022828.6571-1-sarvesh20123@gmail.com>
Date: Fri, 8 Nov 2024 07:58:28 +0530
From: Saru2003 <sarvesh20123@...il.com>
To: johannes@...solutions.net
Cc: davem@...emloft.net,
edumazet@...gle.com,
kuba@...nel.org,
pabeni@...hat.com,
linux-wireless@...r.kernel.org,
netdev@...r.kernel.org,
linux-kernel@...r.kernel.org,
Saru2003 <sarvesh20123@...il.com>
Subject: [PATCH] Fix: Ensure auth_data and ap_addr are properly set before marking STA as authenticated
Signed-off-by: Saru2003 <sarvesh20123@...il.com>
---
net/mac80211/mlme.c | 11 +++++++++--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/net/mac80211/mlme.c b/net/mac80211/mlme.c
index 735e78adb0db..a1ca7385dc1b 100644
--- a/net/mac80211/mlme.c
+++ b/net/mac80211/mlme.c
@@ -4247,8 +4247,15 @@ static void ieee80211_auth_challenge(struct ieee80211_sub_if_data *sdata,
static bool ieee80211_mark_sta_auth(struct ieee80211_sub_if_data *sdata)
{
struct ieee80211_if_managed *ifmgd = &sdata->u.mgd;
- const u8 *ap_addr = ifmgd->auth_data->ap_addr;
+ const u8 *ap_addr;
struct sta_info *sta;
+
+ if (!ifmgd->auth_data || !ifmgd->auth_data->ap_addr) {
+ sdata_info(sdata, "auth_data not set or ap_addr missing\n");
+ return false;
+ }
+
+ ap_addr = ifmgd->auth_data->ap_addr;
lockdep_assert_wiphy(sdata->local->hw.wiphy);
@@ -4261,7 +4268,7 @@ static bool ieee80211_mark_sta_auth(struct ieee80211_sub_if_data *sdata)
/* move station state to auth */
sta = sta_info_get(sdata, ap_addr);
if (!sta) {
- WARN_ONCE(1, "%s: STA %pM not found", sdata->name, ap_addr);
+ sdata_info(sdata, "STA %pM not found, skipping authentication mark\n", ap_addr);
return false;
}
if (sta_info_move_state(sta, IEEE80211_STA_AUTH)) {
--
2.43.0
Powered by blists - more mailing lists