linux-kernel - Re: [PATCH] kernel/irq/proc: performance: replace seq_printf with seq_put_decimal_ull

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3319cd6e.b980.1930c63b1e5.Coremail.00107082@163.com>
Date: Fri, 8 Nov 2024 23:28:00 +0800 (CST)
From: "David Wang" <00107082@....com>
To: "Thomas Gleixner" <tglx@...utronix.de>
Cc: richard.henderson@...aro.org, linux@...linux.org.uk, catalin.marinas@....com, 
	will@...nel.org, guoren@...nel.org, chenhuacai@...nel.org, 
	kernel@...0n.name, James.Bottomley@...senPartnership.com, 
	deller@....de, mpe@...erman.id.au, paul.walmsley@...ive.com, 
	ysato@...rs.sourceforge.jp, dalias@...c.org, 
	glaubitz@...sik.fu-berlin.de, davem@...emloft.net, 
	andreas@...sler.com, mingo@...hat.com, bp@...en8.de, 
	dave.hansen@...ux.intel.com, x86@...nel.org, chris@...kel.net, 
	jcmvbkbc@...il.com, linux-kernel@...r.kernel.org, 
	linux-alpha@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, 
	linux-csky@...r.kernel.org, loongarch@...ts.linux.dev, 
	linux-parisc@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org, 
	linux-riscv@...ts.infradead.org, linux-sh@...r.kernel.org, 
	sparclinux@...r.kernel.org
Subject: Re: [PATCH] kernel/irq/proc: performance: replace seq_printf with
 seq_put_decimal_ull_width

Hi,  

At 2024-11-08 22:25:13, "Thomas Gleixner" <tglx@...utronix.de> wrote:
>David!
>
>On Sun, Nov 03 2024 at 16:05, David Wang wrote:
>
>$Subject: [PATCH] kernel/irq/proc: performance: ...
>
>That's not a valid subsystem prefix.

copy that~

>
>> seq_printf is costy, when stress reading /proc/interrupts, profiling indicates
>> seq_printf takes about ~47% of show_interrupts samples:
>
>Also please follow the documentation for denoting functions in change
>logs:
>
>https://www.kernel.org/doc/html/latest/process/maintainer-tip.html#function-references-in-changelogs
>

copy that~

>>  arch/alpha/kernel/irq.c     |   8 +--
>>  arch/arm/kernel/smp.c       |   4 +-
>>  arch/arm64/kernel/smp.c     |   3 +-
>>  arch/csky/kernel/smp.c      |   4 +-
>>  arch/loongarch/kernel/smp.c |   2 +-
>>  arch/parisc/kernel/irq.c    |  34 ++++++------
>>  arch/powerpc/kernel/irq.c   |  44 ++++++++--------
>>  arch/riscv/kernel/smp.c     |   3 +-
>>  arch/sh/kernel/irq.c        |   4 +-
>>  arch/sparc/kernel/irq_32.c  |  12 ++---
>>  arch/sparc/kernel/irq_64.c  |   4 +-
>>  arch/x86/kernel/irq.c       | 100 ++++++++++++++++++------------------
>>  arch/xtensa/kernel/irq.c    |   2 +-
>>  arch/xtensa/kernel/smp.c    |   4 +-
>>  kernel/irq/proc.c           |   6 ++-
>
>There is no dependency on these changes. So please split them up into
>seperate patches for core and the individual architectures.an

Thanks for all the review, I will make a patchset for this.
>
>Thanks,
>
>        tglx


David