linux-kernel - Re: [RFC] module: Strict per-modname namespaces

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20241108153552.GD6497@noisy.programming.kicks-ass.net>
Date: Fri, 8 Nov 2024 16:35:52 +0100
From: Peter Zijlstra <peterz@...radead.org>
To: "H. Peter Anvin" <hpa@...or.com>
Cc: mcgrof@...nel.org, x86@...nel.org, petr.pavlu@...e.com,
	samitolvanen@...gle.com, da.gomez@...sung.com, masahiroy@...nel.org,
	nathan@...nel.org, nicolas@...sle.eu, linux-kernel@...r.kernel.org,
	linux-modules@...r.kernel.org, linux-kbuild@...r.kernel.org,
	hch@...radead.org, gregkh@...uxfoundation.org
Subject: Re: [RFC] module: Strict per-modname namespaces

On Fri, Nov 08, 2024 at 04:28:58PM +0100, H. Peter Anvin wrote:
> >@@ -1700,11 +1715,7 @@ static void check_exports(struct module *mod)
> > 		s->crc_valid = exp->crc_valid;
> > 		s->crc = exp->crc;
> > 
> >-		basename = strrchr(mod->name, '/');
> >-		if (basename)
> >-			basename++;
> >-		else
> >-			basename = mod->name;
> >+		basename = mod_basename(mod->name);
> > 
> > 		if (!contains_namespace(&mod->imported_namespaces, exp->namespace)) {
> > 			modpost_log(!allow_missing_ns_imports,
> 
> I presume this only applies to code compiled as dynamic modules, not compiled into the kernel?

Yes, the built-in modules get the regular linker to resolve relocations.
Nothing much we can do about that.