[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Zy42LfWaiWHJ12Nw@debian>
Date: Fri, 8 Nov 2024 17:02:53 +0100
From: Guillaume Nault <gnault@...hat.com>
To: Breno Leitao <leitao@...ian.org>
Cc: Jonathan Corbet <corbet@....net>, Akinobu Mita <akinobu.mita@...il.com>,
"David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
Simon Horman <horms@...nel.org>,
Andrew Morton <akpm@...ux-foundation.org>,
linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org,
netdev@...r.kernel.org
Subject: Re: [PATCH net-next v6] net: Implement fault injection forcing skb
reallocation
On Thu, Nov 07, 2024 at 08:11:44AM -0800, Breno Leitao wrote:
> Introduce a fault injection mechanism to force skb reallocation. The
> primary goal is to catch bugs related to pointer invalidation after
> potential skb reallocation.
Nice to see this kind of debug option being worked on!
> +static bool should_fail_net_realloc_skb(struct sk_buff *skb)
> +{
> + struct net_device *net = skb->dev;
It's confusing to see a variable called "net" pointing to a struct
net_device. "net" generally refers to struct net.
In case v7 is needed, it'd be nice to call this variable "dev".
Looks good to me otherwise.
Acked-by: Guillaume Nault <gnault@...hat.com>
Powered by blists - more mailing lists