linux-kernel - [PATCH RFC v3 1/4] module: remove module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20241108-modules-ro_after_init-v3-1-6dd041b588a5@samsung.com>
Date: Fri, 08 Nov 2024 17:12:13 +0100
From: Daniel Gomez via B4 Relay <devnull+da.gomez.samsung.com@...nel.org>
To: Luis Chamberlain <mcgrof@...nel.org>, Petr Pavlu <petr.pavlu@...e.com>, 
 Sami Tolvanen <samitolvanen@...gle.com>, 
 Christophe Leroy <christophe.leroy@...roup.eu>, 
 Thomas Gleixner <tglx@...utronix.de>, Jinjie Ruan <ruanjinjie@...wei.com>, 
 Jens Axboe <axboe@...nel.dk>
Cc: "Daniel Gomez (Samsung)" <d+samsung@...ces.com>, 
 linux-modules@...r.kernel.org, linux-kernel@...r.kernel.org, 
 Daniel Gomez <da.gomez@...sung.com>
Subject: [PATCH RFC v3 1/4] module: remove module_deallocate() unused param

From: Daniel Gomez <da.gomez@...sung.com>

The module_deallocate() function no longer requires the struct load_info
parameter as of commit 48fd11880b5ef04270be8a87d9a9a9ee2fdae338 ("module:
Fix performance regression on modules with large symbol tables"). This
commit removes the now-unused parameter.

No functional changes.

Signed-off-by: Daniel Gomez <da.gomez@...sung.com>
---
 kernel/module/main.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/kernel/module/main.c b/kernel/module/main.c
index 5399c182b3cb..e0b2a8d9e324 100644
--- a/kernel/module/main.c
+++ b/kernel/module/main.c
@@ -2767,7 +2767,7 @@ static struct module *layout_and_allocate(struct load_info *info, int flags)
 }
 
 /* mod is no longer valid after this! */
-static void module_deallocate(struct module *mod, struct load_info *info)
+static void module_deallocate(struct module *mod)
 {
 	percpu_modfree(mod);
 	module_arch_freeing_init(mod);
@@ -3417,7 +3417,7 @@ static int load_module(struct load_info *info, const char __user *uargs,
 				       mod->mem[type].size);
 	}
 
-	module_deallocate(mod, info);
+	module_deallocate(mod);
  free_copy:
 	/*
 	 * The info->len is always set. We distinguish between

-- 
2.39.2