linux-kernel - Re: [PATCH v3 2/2] dt-bindings: input: gt7986u-spifw: Remove hid-report-addr property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241108161350.GA2313139-robh@kernel.org>
Date: Fri, 8 Nov 2024 10:13:50 -0600
From: Rob Herring <robh@...nel.org>
To: Charles Wang <charles.goodix@...il.com>
Cc: krzk@...nel.org, hbarnor@...omium.org, dianders@...omium.org,
	conor.dooley@...rochip.com, dmitry.torokhov@...il.com,
	jikos@...nel.org, bentiss@...nel.org, linux-input@...r.kernel.org,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 2/2] dt-bindings: input: gt7986u-spifw: Remove
 hid-report-addr property

On Fri, Nov 08, 2024 at 08:03:11PM +0800, Charles Wang wrote:
> Since all boards use the same address, drop the goodix,hid-report-addr
> property and hardcode it in the driver as a default value.

Where's the driver change?

I don't see the point in defining this and then removing it in the next 
patch.

> 
> Signed-off-by: Charles Wang <charles.goodix@...il.com>
> ---
>  .../devicetree/bindings/input/goodix,gt7986u-spifw.yaml    | 7 -------
>  1 file changed, 7 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/input/goodix,gt7986u-spifw.yaml b/Documentation/devicetree/bindings/input/goodix,gt7986u-spifw.yaml
> index 8105b9ce2..c9e346a60 100644
> --- a/Documentation/devicetree/bindings/input/goodix,gt7986u-spifw.yaml
> +++ b/Documentation/devicetree/bindings/input/goodix,gt7986u-spifw.yaml
> @@ -36,11 +36,6 @@ properties:
>    reset-gpios:
>      maxItems: 1
>  
> -  goodix,hid-report-addr:
> -    $ref: /schemas/types.yaml#/definitions/uint32
> -    description:
> -      The register address for retrieving HID report data.
> -
>    spi-max-frequency: true
>  
>  required:
> @@ -48,7 +43,6 @@ required:
>    - reg
>    - interrupts
>    - reset-gpios
> -  - goodix,hid-report-addr

Dropping a required property is an ABI break.

A devicetree that passes with the schema will not work on current 
kernels that require this property.

>  
>  unevaluatedProperties: false
>  
> @@ -68,7 +62,6 @@ examples:
>          interrupts = <25 IRQ_TYPE_LEVEL_LOW>;
>          reset-gpios = <&gpio1 1 GPIO_ACTIVE_LOW>;
>          spi-max-frequency = <10000000>;
> -        goodix,hid-report-addr = <0x22c8c>;
>        };
>      };
>  
> -- 
> 2.43.0
>