linux-kernel - Re: [PATCH] drm/rockchip: dsi: convert to dev_err

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <D5GY0NXYFLS9.1YHBZ5502R764@cknow.org>
Date: Fri, 08 Nov 2024 17:37:51 +0100
From: "Diederik de Haas" <didi.debian@...ow.org>
To: Heiko Stübner <heiko@...ech.de>,
 <linux-rockchip@...ts.infradead.org>, <dri-devel@...ts.freedesktop.org>
Cc: <dsimic@...jaro.org>, <andy.yan@...k-chips.com>,
 <maarten.lankhorst@...ux.intel.com>, <mripard@...nel.org>,
 <tzimmermann@...e.de>, <linux-kernel@...r.kernel.org>, "Heiko Stuebner"
 <heiko.stuebner@...rry.de>
Subject: Re: [PATCH] drm/rockchip: dsi: convert to dev_err_probe in probe
 function

On Fri Nov 8, 2024 at 5:31 PM CET, Heiko Stübner wrote:
> Am Freitag, 8. November 2024, 16:21:24 CET schrieb Diederik de Haas:
> > On Fri Nov 8, 2024 at 3:44 PM CET, Heiko Stuebner wrote:
> > > From: Heiko Stuebner <heiko.stuebner@...rry.de>
> > >
> > > DRM_DEV_ERROR is deprecated and using dev_err_probe saves quite a number
> > > of lines too, so convert the error prints for the dsi-driver.
> > >
> > > Signed-off-by: Heiko Stuebner <heiko.stuebner@...rry.de>
> > 
> > Should this have a Fixes tag?
> > Because in the PineTab2 case it reported an error, which was actually
> > just a deferred probe.
>
> A deferred-probe is an error ;-)   -517 in fact  ... just that convention
> nowadays is to not actively report on it but "fail" silently.

Good to know, thanks :)

> So personally I don't really consider it a fix, but more a style thing.
> I guess I'll let others chime in for that.

Then I agree that it should not have a Fixes tag.

Cheers,
  Diederik

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)