linux-kernel - Re: [PATCH] cdx: Fix cdx_mmap_resource() after constifying attr in ->mmap()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241108175437.GD2564051@thelio-3990X>
Date: Fri, 8 Nov 2024 10:54:37 -0700
From: Nathan Chancellor <nathan@...nel.org>
To: Thomas Weißschuh <thomas@...ssschuh.net>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Thomas Weißschuh <linux@...ssschuh.net>,
	Nipun Gupta <nipun.gupta@....com>,
	Nikhil Agarwal <nikhil.agarwal@....com>,
	linux-kernel@...r.kernel.org, patches@...ts.linux.dev
Subject: Re: [PATCH] cdx: Fix cdx_mmap_resource() after constifying attr in
 ->mmap()

On Fri, Nov 08, 2024 at 12:23:50PM -0500, Thomas Weißschuh wrote:
> Nov 7, 2024 12:07:56 Nathan Chancellor <nathan@...nel.org>:
> > Fixes: 94a20fb9af16 ("sysfs: treewide: constify attribute callback of bin_attribute::mmap()")
> 
> I'm not sure about the Fixes tag.
> cdx.c is not yet in mainline and this change should be folded into the cdx patch or the sysfs patch, depending on their order in the merge window.
> I guess Greg will take care of it.

This code is in mainline, so I think the Fixes tag is correct?

  $ git grep cdx_mmap_resource v6.12-rc1 drivers/cdx/cdx.c
  v6.12-rc1:drivers/cdx/cdx.c: * cdx_mmap_resource - map a CDX resource into user memory space
  v6.12-rc1:drivers/cdx/cdx.c:static int cdx_mmap_resource(struct file *fp, struct kobject *kobj,
  v6.12-rc1:drivers/cdx/cdx.c:        res_attr->mmap = cdx_mmap_resource;

The error is reproducible on driver-core-next since that is what I based
this change on.

Thanks for the review!

Cheers,
Nathan