linux-kernel - Re: [PATCH v2 04/11] clk: qcom: camcc-qcs615: Add QCS615 camera clock controller driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <90323c59-acca-488a-b957-f36634787858@quicinc.com>
Date: Fri, 8 Nov 2024 09:30:03 +0530
From: Taniya Das <quic_tdas@...cinc.com>
To: Bryan O'Donoghue <bryan.odonoghue@...aro.org>,
        Michael Turquette
	<mturquette@...libre.com>,
        Stephen Boyd <sboyd@...nel.org>,
        Bjorn Andersson
	<andersson@...nel.org>,
        Abhishek Sahu <absahu@...eaurora.org>, Rob Herring
	<robh@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        Conor Dooley
	<conor+dt@...nel.org>,
        Catalin Marinas <catalin.marinas@....com>,
        Will Deacon
	<will@...nel.org>
CC: Ajit Pandey <quic_ajipan@...cinc.com>,
        Imran Shaik
	<quic_imrashai@...cinc.com>,
        Jagadeesh Kona <quic_jkona@...cinc.com>,
        <linux-arm-msm@...r.kernel.org>, <linux-clk@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH v2 04/11] clk: qcom: camcc-qcs615: Add QCS615 camera clock
 controller driver



On 11/1/2024 5:59 PM, Bryan O'Donoghue wrote:
> On 01/11/2024 10:38, Taniya Das wrote:
>> +    .vco_val = 0x2 << 20,
> 
> vco_val = BIT(21)
> 

Will fix it in the next patch.

>> +    .vco_mask = 0x3 << 20,
> 
> Instead of bit shifting couldn't we just use GENMASK ?
> 
> Aside from anything else shifting a hex value by a decimal value isn't 
> the clearest code in the world.
> 
> vco_mask = GENMASK(21, 20)
> 
> Much cleaner.
> 
> drivers/clk/qcom/gcc-sm6115.c
> 
> Same comment for all of the bit-shifts in the series, I appreciate the 
> shifts are what the downstream code does but BIT/GENMASK does this job 
> better.
> 
I agree, will fix it in the next patch.

> Once fixed you can add my
> 
> Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@...aro.org>
> 
> to this file


-- 
Thanks & Regards,
Taniya Das.