linux-kernel - Re: [PATCH v2] net: rfkill: gpio: Add check for clk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f1a0801e4ce55cdccfa809a6e49d839aabf1a0ae.camel@sipsolutions.net>
Date: Fri, 08 Nov 2024 08:47:28 +0100
From: Johannes Berg <johannes@...solutions.net>
To: Mingwei Zheng <zmw12306@...il.com>
Cc: linville@...driver.com, rklein@...dia.com,
 linux-wireless@...r.kernel.org,  linux-kernel@...r.kernel.org, Jiasheng
 Jiang <jiashengjiangcool@...il.com>
Subject: Re: [PATCH v2] net: rfkill: gpio: Add check for clk_enable()

On Thu, 2024-11-07 at 17:20 -0500, Mingwei Zheng wrote:
> Add check for the return value of clk_enable() to catch the potential
> error.

Wait ... is someone running an experiment again? ;-)
> 
> diff --git a/net/rfkill/rfkill-gpio.c b/net/rfkill/rfkill-gpio.c
> index c268c2b011f4..a87bb99231a6 100644
> --- a/net/rfkill/rfkill-gpio.c
> +++ b/net/rfkill/rfkill-gpio.c
> @@ -31,9 +31,13 @@ struct rfkill_gpio_data {
>  static int rfkill_gpio_set_power(void *data, bool blocked)
>  {
>  	struct rfkill_gpio_data *rfkill = data;
> +	int ret;

You could move that into the if.

> -	if (!blocked && !IS_ERR(rfkill->clk) && !rfkill->clk_enabled)
> -		clk_enable(rfkill->clk);
> +	if (!blocked && !IS_ERR(rfkill->clk) && !rfkill->clk_enabled) {
> +		ret = clk_enable(rfkill->clk);
> +		if (!ret)
> +			return ret;
> +	}
> 

but this is obviously wrong anyway.

johannes