linux-kernel - [PATCH] perf list: fix arguments order issue for events printing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241108082959.10319-1-jean-philippe.romain@foss.st.com>
Date: Fri, 8 Nov 2024 09:29:59 +0100
From: Jean-Philippe Romain <jean-philippe.romain@...s.st.com>
To: Ingo Molnar <mingo@...hat.com>,
        Arnaldo Carvalho de Melo
	<acme@...nel.org>,
        Namhyung Kim <namhyung@...nel.org>,
        Mark Rutland
	<mark.rutland@....com>,
        Alexander Shishkin
	<alexander.shishkin@...ux.intel.com>,
        Jiri Olsa <jolsa@...nel.org>, Ian
 Rogers <irogers@...gle.com>,
        Adrian Hunter <adrian.hunter@...el.com>,
        Liang
 Kan <kan.liang@...ux.intel.com>
CC: <linux-perf-users@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <fabrice.gasnier@...s.st.com>, <alexandre.torgue@...s.st.com>
Subject: [PATCH] perf list: fix arguments order issue for events printing

Misalignment of callbacks with print_event:
- pmu_name and topic arguments to reverse

Signed-off-by: Jean-Philippe ROMAIN <jean-philippe.romain@...s.st.com>

diff --git a/tools/perf/builtin-list.c b/tools/perf/builtin-list.c
index 65b8cba324be..c5331721dfee 100644
--- a/tools/perf/builtin-list.c
+++ b/tools/perf/builtin-list.c
@@ -112,7 +112,7 @@ static void wordwrap(FILE *fp, const char *s, int start, int max, int corr)
 	}
 }
 
-static void default_print_event(void *ps, const char *pmu_name, const char *topic,
+static void default_print_event(void *ps, const char *topic, const char *pmu_name,
 				const char *event_name, const char *event_alias,
 				const char *scale_unit __maybe_unused,
 				bool deprecated, const char *event_type_desc,
@@ -353,7 +353,7 @@ static void fix_escape_fprintf(FILE *fp, struct strbuf *buf, const char *fmt, ..
 	fputs(buf->buf, fp);
 }
 
-static void json_print_event(void *ps, const char *pmu_name, const char *topic,
+static void json_print_event(void *ps, const char *topic, const char *pmu_name,
 			     const char *event_name, const char *event_alias,
 			     const char *scale_unit,
 			     bool deprecated, const char *event_type_desc,
-- 
2.34.1