linux-kernel - Re: [PATCH 1/3] dt-bindings: trivial-devices: Add NXP P3T1085UK I3C/I2C temperature sensor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241108084547.dzmxgdwllwvbiw5n@pengutronix.de>
Date: Fri, 8 Nov 2024 09:45:47 +0100
From: Marco Felsch <m.felsch@...gutronix.de>
To: Frank Li <Frank.Li@....com>
Cc: Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Jonathan Cameron <jic23@...nel.org>,
	Lars-Peter Clausen <lars@...afoo.de>,
	Shawn Guo <shawnguo@...nel.org>,
	Sascha Hauer <s.hauer@...gutronix.de>,
	Pengutronix Kernel Team <kernel@...gutronix.de>,
	Fabio Estevam <festevam@...il.com>, devicetree@...r.kernel.org,
	imx@...ts.linux.dev, linux-iio@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 1/3] dt-bindings: trivial-devices: Add NXP P3T1085UK
 I3C/I2C temperature sensor

On 24-11-07, Frank Li wrote:
> P3T1085UK is a temperature-to-digital converter with a -40 °C to +125 °C
> range. The device can be communicated by a controller via the 2-wire serial
> I3C (up to 12.5 MHz) and I2C (up to 3.4 MHz) interface.
> 
> Add it to trivial-devices.yaml because only one 'reg' and 'interrupts'
> needs.
> 
> Signed-off-by: Frank Li <Frank.Li@....com>
> ---
>  Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml
> index 6ecd6432b021b..361943b3d73bc 100644
> --- a/Documentation/devicetree/bindings/trivial-devices.yaml
> +++ b/Documentation/devicetree/bindings/trivial-devices.yaml
> @@ -301,6 +301,8 @@ properties:
>            - national,lm92
>              # Nuvoton Temperature Sensor
>            - nuvoton,w83773g
> +            # NXP I2C/I3C Temperature Sensor (-40 °C to +125 °C)
> +          - nxp,p3t1085

The description of this binding says:

"This is a list of trivial I2C and SPI devices ..."

but you add a I2C and I3C device.

Also I really like to see that you add a "power-supply" property which
is most the time missing for such simple devices but always required.

Regards,
  Marco

>              # OKI ML86V7667 video decoder
>            - oki,ml86v7667
>              # ON Semiconductor ADT7462 Temperature, Voltage Monitor and Fan Controller
> 
> -- 
> 2.34.1
> 
> 
>