linux-kernel - Re: [PATCH 06/10] mtd: intel-dg: wake card on operations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87cyj6aylg.fsf@bootlin.com>
Date: Fri, 08 Nov 2024 10:01:15 +0100
From: Miquel Raynal <miquel.raynal@...tlin.com>
To: Rodrigo Vivi <rodrigo.vivi@...el.com>
Cc: "Usyskin, Alexander" <alexander.usyskin@...el.com>,  "Gupta, Anshuman"
 <anshuman.gupta@...el.com>,  "Deak, Imre" <imre.deak@...el.com>,  "Richard
 Weinberger" <richard@....at>,  Vignesh Raghavendra <vigneshr@...com>,  "De
 Marchi, Lucas" <lucas.demarchi@...el.com>,  Thomas Hellström
 <thomas.hellstrom@...ux.intel.com>,  "Maarten Lankhorst"
 <maarten.lankhorst@...ux.intel.com>,  Maxime Ripard <mripard@...nel.org>,
  Thomas Zimmermann <tzimmermann@...e.de>,  David Airlie
 <airlied@...il.com>,  Simona Vetter <simona@...ll.ch>,  Jani Nikula
 <jani.nikula@...ux.intel.com>,  Joonas Lahtinen
 <joonas.lahtinen@...ux.intel.com>,  Tvrtko Ursulin <tursulin@...ulin.net>,
  "Weil, Oren jer" <oren.jer.weil@...el.com>,
  "linux-mtd@...ts.infradead.org" <linux-mtd@...ts.infradead.org>,
  "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
  "intel-gfx@...ts.freedesktop.org" <intel-gfx@...ts.freedesktop.org>,
  "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 06/10] mtd: intel-dg: wake card on operations


>> > That's the part that I'm not sure if I agree. if I remember from some
>> > experiments in the past,
>> > when you call to wake up the child, the parent will wakeup first anyway.
>> > 
>> The child (mtd device) does not exist at this point of time.
>> To create MTD device, the partition table should be provided
>> and it read directly from flash that should be powered to do read.
>
> I don't understand... you have the mtd->dev at this point... this is
> the one you should be touching, not the mtd->dev.parent... even at the
> probe, but moreover on everywhere else as well.
>
>> 
>> > > Considering above, is this move is justified?
>> > > Also, MTD drivers tend to enable parent rpm, not its own one.
>> > 
>> > What other drivers are you looking for reference?
>> 
>> drivers/mtd/nand/raw/tegra_nand.c
>> drivers/mtd/nand/raw/renesas-nand-controller.c
>> drivers/mtd/maps/physmap-core.c
>
> I see they getting pdev->dev... not the parent...

That's three drivers where there is probably room for improvement.

These differences are subtle and likely un-catch during review. Feel
free to correct the drivers if you think they are wrong and more
importantly, do the correct thing in your own.

Thanks,
Miquèl