linux-kernel - Re: [PATCH] hostfs: Fix the NULL vs IS_ERR() bug for __filemap_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <065b0d76aeea7d3543d3eab302167af039e8f913.camel@sipsolutions.net>
Date: Fri, 08 Nov 2024 10:17:24 +0100
From: Johannes Berg <johannes@...solutions.net>
To: Peng Zhang <zhangpeng362@...wei.com>, linux-um@...ts.infradead.org, 
	linux-kernel@...r.kernel.org, Christian Brauner <brauner@...nel.org>
Cc: richard@....at, anton.ivanov@...bridgegreys.com, willy@...radead.org, 
	josef@...icpanda.com, brauner@...nel.org, zhangxiaoxu5@...wei.com, 
	wanghai38@...wei.com
Subject: Re: [PATCH] hostfs: Fix the NULL vs IS_ERR() bug for
 __filemap_get_folio()

On Mon, 2024-11-04 at 20:34 +0800, Peng Zhang wrote:
> From: ZhangPeng <zhangpeng362@...wei.com>
> 
> The __filemap_get_folio() function returns error pointers.
> It never returns NULL. So use IS_ERR() to check it.
> 
> Fixes: 1da86618bdce ("fs: Convert aops->write_begin to take a folio")
> Signed-off-by: ZhangPeng <zhangpeng362@...wei.com>

Not sure it's critical, but for um I wasn't planning to send a pull
request for 6.12-rc (and I suspect Richard also wasn't, as there are no
other fixes). Also, the original commit went through another tree.

Christian what do you think? Do you want to pick it up? Or should we
pick it up via um, but then likely only for 6.13?

If you could pick it up:
Acked-by: Johannes Berg <johannes@...solutions.net>

johannes