linux-kernel - Re: [PATCH 2/2] procfs: implement PROCFS_SET

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202411081749.pXnGtt8H-lkp@intel.com>
Date: Fri, 8 Nov 2024 18:01:31 +0800
From: kernel test robot <lkp@...el.com>
To: Stas Sergeev <stsp2@...dex.ru>, linux-kernel@...r.kernel.org
Cc: oe-kbuild-all@...ts.linux.dev, Stas Sergeev <stsp2@...dex.ru>,
	Eric Biederman <ebiederm@...ssion.com>,
	Andy Lutomirski <luto@...nel.org>, Aleksa Sarai <cyphar@...har.com>,
	Alexander Viro <viro@...iv.linux.org.uk>,
	Christian Brauner <brauner@...nel.org>, Jan Kara <jack@...e.cz>,
	Thomas Gleixner <tglx@...utronix.de>,
	Jeff Layton <jlayton@...nel.org>,
	John Johansen <john.johansen@...onical.com>,
	Chengming Zhou <chengming.zhou@...ux.dev>,
	Casey Schaufler <casey@...aufler-ca.com>,
	Adrian Ratiu <adrian.ratiu@...labora.com>,
	Felix Moessbauer <felix.moessbauer@...mens.com>,
	Jens Axboe <axboe@...nel.dk>, Oleg Nesterov <oleg@...hat.com>,
	"Serge E. Hallyn" <serge@...lyn.com>, linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH 2/2] procfs: implement PROCFS_SET_GROUPS ioctl

Hi Stas,

kernel test robot noticed the following build errors:

[auto build test ERROR on brauner-vfs/vfs.all]
[also build test ERROR on linus/master v6.12-rc6 next-20241107]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Stas-Sergeev/procfs-avoid-some-usages-of-seq_file-private-data/20241108-060856
base:   https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git vfs.all
patch link:    https://lore.kernel.org/r/20241107215821.1514623-3-stsp2%40yandex.ru
patch subject: [PATCH 2/2] procfs: implement PROCFS_SET_GROUPS ioctl
config: arc-randconfig-001-20241108 (https://download.01.org/0day-ci/archive/20241108/202411081749.pXnGtt8H-lkp@intel.com/config)
compiler: arc-elf-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241108/202411081749.pXnGtt8H-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202411081749.pXnGtt8H-lkp@intel.com/

All errors (new ones prefixed by >>):

   fs/proc/base.c: In function 'do_proc_setgroups':
>> fs/proc/base.c:891:15: error: implicit declaration of function 'set_current_groups'; did you mean 'get_current_groups'? [-Werror=implicit-function-declaration]
     891 |         err = set_current_groups(gi);
         |               ^~~~~~~~~~~~~~~~~~
         |               get_current_groups
   cc1: some warnings being treated as errors

Kconfig warnings: (for reference only)
   WARNING: unmet direct dependencies detected for GET_FREE_REGION
   Depends on [n]: SPARSEMEM [=n]
   Selected by [y]:
   - RESOURCE_KUNIT_TEST [=y] && RUNTIME_TESTING_MENU [=y] && KUNIT [=y]


vim +891 fs/proc/base.c

   870	
   871	static int do_proc_setgroups(const struct cred *task_cred,
   872				     const struct cred *cur_cred,
   873				     const struct cred *f_cred)
   874	{
   875		struct group_info *cgi = get_group_info(cur_cred->group_info);
   876		struct group_info *gi = get_group_info(task_cred->group_info);
   877		int err;
   878	
   879		/* Make sure groups didn't change since file open. */
   880		err = -EPERM;
   881		if (f_cred->group_info != gi)
   882			goto out_gi;
   883		/* Don't error if the process is setting the same list again. */
   884		err = 0;
   885		if (cgi == gi)
   886			goto out_gi;
   887	
   888		err = -EPERM;
   889		if (!can_borrow_groups(cur_cred, f_cred))
   890			goto out_gi;
 > 891		err = set_current_groups(gi);
   892	
   893	out_gi:
   894		put_group_info(gi);
   895		put_group_info(cgi);
   896		return err;
   897	}
   898	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki