linux-kernel - Re: [PATCH md-6.13] md: remove bitmap file support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAPhsuW4tcXqL3K3Pdgy_LDK9E6wnuzSkgWbmyXXqAa=qjAnv7A@mail.gmail.com>
Date: Thu, 7 Nov 2024 17:28:43 -0800
From: Song Liu <song@...nel.org>
To: Yu Kuai <yukuai1@...weicloud.com>
Cc: linux-raid@...r.kernel.org, linux-kernel@...r.kernel.org, 
	yi.zhang@...wei.com, yangerkun@...wei.com, "yukuai (C)" <yukuai3@...wei.com>
Subject: Re: [PATCH md-6.13] md: remove bitmap file support

On Thu, Nov 7, 2024 at 5:03 PM Yu Kuai <yukuai1@...weicloud.com> wrote:
>
> Hi,
>
> 在 2024/11/08 7:41, Song Liu 写道:
> > On Thu, Nov 7, 2024 at 5:02 AM Yu Kuai <yukuai1@...weicloud.com> wrote:
> >>
> >> From: Yu Kuai <yukuai3@...wei.com>
> >>
> >> The bitmap file has been marked as deprecated for more than a year now,
> >> let's remove it, and we don't need to care about this case in the new
> >> bitmap.
> >>
> >> Signed-off-by: Yu Kuai <yukuai3@...wei.com>
> >
> > What happens when an old array with bitmap file boots into a kernel
> > without bitmap file support?
>
> If mdadm is used with bitmap file support, then kenel will just ignore
> the bitmap, the same as none bitmap. Perhaps it's better to leave a
> error message?

Yes, we should print some error message before assembling the array.

> And if mdadm is updated, reassemble will fail.

I think we should ship this with 6.14 (not 6.13), so that we have
more time testing different combinations of old/new mdadm
and kernel. WDYT?

Thanks,
Song