linux-kernel - Re: [PATCH 2/3] media: i2c: imx219: make HBLANK r/w to allow longer exposures

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Zy3oKnHBiGOq8Uoj@kekkonen.localdomain>
Date: Fri, 8 Nov 2024 10:30:02 +0000
From: Sakari Ailus <sakari.ailus@...ux.intel.com>
To: Dave Stevenson <dave.stevenson@...pberrypi.com>
Cc: Jai Luthra <jai.luthra@...asonboard.com>,
	Mauro Carvalho Chehab <mchehab@...nel.org>,
	linux-media@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/3] media: i2c: imx219: make HBLANK r/w to allow longer
 exposures

Hi Dave,

On Thu, Nov 07, 2024 at 12:43:52PM +0000, Dave Stevenson wrote:
> Hi Sakari
> 
> On Fri, 1 Nov 2024 at 08:48, Sakari Ailus <sakari.ailus@...ux.intel.com> wrote:
> >
> > Hi Jai,
> >
> > On Tue, Oct 29, 2024 at 02:27:36PM +0530, Jai Luthra wrote:
> > > From: Dave Stevenson <dave.stevenson@...pberrypi.com>
> > >
> > > The HBLANK control was read-only, and always configured such
> > > that the sensor HTS register was 3448. This limited the maximum
> > > exposure time that could be achieved to around 1.26 secs.
> > >
> > > Make HBLANK read/write so that the line time can be extended,
> > > and thereby allow longer exposures (and slower frame rates).
> > > Retain the overall HTS setting when changing modes rather than
> > > resetting it to a default.
> >
> > It looks like this changes horizontal blanking at least in some cases. Does
> > this also work as expected in binned modes, for instance?
> >
> > Many sensors have image quality related issues on untested albeit
> > functional line length values.
> >
> > So my question is: how has this been validated?
> 
> Validated by Sony, or others?
> I've tested a range of values in all modes and not observed any image
> quality issues.

Somehow at least. :-)

> 
> From previous discussions with Sony, they always provide their big
> spreadsheet of register values for the specific mode and frame rate
> requested. I don't think they even officially state that changing
> VTS/FRM_LENGTH_LINES to change the framerate is permitted.
> There are some Sony datasheets (eg imx258) that state "set to X. Any
> other value please confirm with Sony", but that isn't the case for the
> imx219 datasheet. I take that as it is permitted within the defined
> ranges.

I'm not that much concerned of vertical blanking, changing that within the
valid range has effects on the image itself very seldom. Horizontal
blanking is different though and this is what the patch makes changeable,
including a change in the default value. Of course there are big
differences between sensors here.

-- 
Kind regards,

Sakari Ailus