linux-kernel - Re: [PATCH v2 3/3] scftorture: Use a lock-less list to free memory.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20241108103252.4EVzazwC@linutronix.de>
Date: Fri, 8 Nov 2024 11:32:52 +0100
From: Sebastian Andrzej Siewior <bigeasy@...utronix.de>
To: Boqun Feng <boqun.feng@...il.com>
Cc: kasan-dev@...glegroups.com, linux-kernel@...r.kernel.org,
	linux-mm@...ck.org, "Paul E. McKenney" <paulmck@...nel.org>,
	Marco Elver <elver@...gle.com>,
	Peter Zijlstra <peterz@...radead.org>,
	Tomas Gleixner <tglx@...utronix.de>,
	Vlastimil Babka <vbabka@...e.cz>, akpm@...ux-foundation.org,
	cl@...ux.com, iamjoonsoo.kim@....com, longman@...hat.com,
	penberg@...nel.org, rientjes@...gle.com, sfr@...b.auug.org.au
Subject: Re: [PATCH v2 3/3] scftorture: Use a lock-less list to free memory.

On 2024-11-07 12:45:25 [-0800], Boqun Feng wrote:
> > @@ -538,6 +567,8 @@ static void scf_torture_cleanup(void)
> >  
> >  end:
> >  	torture_cleanup_end();
> > +	for (i = 0; i < nthreads; i++)
> 
> This needs to be:
> 
> 	for (i = 0; i < nr_cpu_ids; i++)
> 
> because nthreads can be larger than nr_cpu_ids, and it'll access a
> out-of-bound percpu section.

And I though I learned my lesson last time.
Thank you.

> Regards,
> Boqun

Sebastian