linux-kernel - Re: [PATCH v4 4/6] arm64: Add initial support for Blaize BLZP1600 CB2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <f38f87bf-f413-4dc3-a76e-e653dd4ad6d1@app.fastmail.com>
Date: Fri, 08 Nov 2024 12:36:28 +0100
From: "Arnd Bergmann" <arnd@...db.de>
To: "Niko Pasaloukos" <nikolaos.pasaloukos@...ize.com>,
 "James Cowgill" <james.cowgill@...ize.com>,
 "Matt Redfearn" <matthew.redfearn@...ize.com>,
 "Neil Jones" <neil.jones@...ize.com>, "Rob Herring" <robh@...nel.org>,
 "krzysztof.kozlowski+dt@...aro.org" <krzysztof.kozlowski+dt@...aro.org>,
 "Conor Dooley" <conor+dt@...nel.org>,
 "Catalin Marinas" <catalin.marinas@....com>,
 "Will Deacon" <will@...nel.org>, "Olof Johansson" <olof@...om.net>,
 "Hans Verkuil" <hverkuil-cisco@...all.nl>,
 "Shawn Guo" <shawnguo@...nel.org>,
 "Hugo Villeneuve" <hvilleneuve@...onoff.com>,
 "Andre Przywara" <andre.przywara@....com>,
 Rafał Miłecki <rafal@...ecki.pl>,
 "Bjorn Andersson" <andersson@...nel.org>,
 "Konrad Dybcio" <konrad.dybcio@...aro.org>,
 "AngeloGioacchino Del Regno" <angelogioacchino.delregno@...labora.com>,
 "Nishanth Menon" <nm@...com>,
 "Neil Armstrong" <neil.armstrong@...aro.org>,
 Nícolas F. R. A. Prado <nfraprado@...labora.com>,
 "Johan Hovold" <johan+linaro@...nel.org>
Cc: "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
 "linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH v4 4/6] arm64: Add initial support for Blaize BLZP1600 CB2

On Fri, Nov 8, 2024, at 11:31, Niko Pasaloukos wrote:
> Adds support for the Blaize CB2 development board based on
> BLZP1600 SoC. This consists of a Carrier-Board-2 and a SoM.
>
> The blaize-blzp1600.dtsi is the common part for the SoC,
> blaize-blzp1600-som.dtsi is the common part for the SoM and
> blaize-blzp1600-cb2.dts is the board specific file.

The split of files seems fine, but a little more information
about what this chip is used for would help, so that developers
looking at the git history later can have an idea.

> Checkpatch: ignore
> Resolves: PESW-2604

I don't understand these, can you turn these into full
english sentences? What checkpatch errors do you see and
why should I ignore them? What is PESW-2604 and how does
it relate to PLZP1600? 

> +#include "blaize-blzp1600-som.dtsi"
> +#include <dt-bindings/net/ti-dp83867.h>

I don't see any references to ti-dp83867.h here, maybe leave
the #include to a later patch that actually starts using it?

> +#include "blaize-blzp1600.dtsi"
> +
> +/ {
> +	memory@0 {
> +		device_type = "memory";
> +		reg = <0x0 0x00000000 0xffffffff>;
> +	};
> +};

Is this an off-by-one error or do you intentionally
leave out the last bit of the 4GB address space?

If the last byte is actually addressable, please just
use #size-cells=<2> and make it the full 0x100000000.

       Arnd