linux-kernel - Re: [PATCH 2/2] dt-bindings: regulator: Add adi,lt8722-regulator.yaml

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <qr72zky2xfy4uzcm7vqnipgx3nkic4hp377jbtha46cktnxncy@52ms2zg3sf7w>
Date: Fri, 8 Nov 2024 12:43:07 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: "Ramon Cristopher M. Calam" <ramoncristopher.calam@...log.com>
Cc: linux-kernel@...r.kernel.org, devicetree@...r.kernel.org, 
	Liam Girdwood <lgirdwood@...il.com>, Mark Brown <broonie@...nel.org>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>
Subject: Re: [PATCH 2/2] dt-bindings: regulator: Add adi,lt8722-regulator.yaml

On Fri, Nov 08, 2024 at 05:35:44PM +0800, Ramon Cristopher M. Calam wrote:
> Add documentation for device tree bindings of LT8722.
> 
> Signed-off-by: Ramon Cristopher M. Calam <ramoncristopher.calam@...log.com>
> ---
>  .../regulator/adi,lt8722-regulator.yaml       | 178 ++++++++++++++++++
>  1 file changed, 178 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/regulator/adi,lt8722-regulator.yaml
> 

This wasn't tested, so limited review follows.

Please use subject prefixes matching the subsystem. You can get them for
example with 'git log --oneline -- DIRECTORY_OR_FILE' on the directory
your patch is touching. For bindings, the preferred subjects are
explained here:
https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters

> diff --git a/Documentation/devicetree/bindings/regulator/adi,lt8722-regulator.yaml b/Documentation/devicetree/bindings/regulator/adi,lt8722-regulator.yaml
> new file mode 100644
> index 000000000000..3fbf788d4154
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/regulator/adi,lt8722-regulator.yaml
> @@ -0,0 +1,178 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +# Copyright (c) 2023 Analog Devices, Inc.
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/regulator/adi,lt8722-regulator.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Analog Devices LT8722 Ultracompact Full Bridge Driver

Driver like motor driver or regulator? Or Linux driver? If the latter
then, drop. Describe the hardware please.


> +
> +maintainers:
> +  - Ramon Cristopher Calam <ramoncristopher.calam@...log.com>
> +
> +description: |

Do not need '|' unless you need to preserve formatting.

That's all folks! More review when this is tested, please.

Best regards,
Krzysztof