[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <c7llcnzthr2ydp4zlyk7rhovwauy5cqeqllvmgmyluypxq3opv@c4suatmd7k3w>
Date: Fri, 8 Nov 2024 13:30:46 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: "Anwar, Md Danish" <a0501179@...com>
Cc: MD Danish Anwar <danishanwar@...com>, conor+dt@...nel.org,
krzk+dt@...nel.org, robh@...nel.org, ssantosh@...nel.org, nm@...com,
Vignesh Raghavendra <vigneshr@...com>, devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
linux-kernel@...r.kernel.org, s-anna@...com, kristo@...nel.org, srk@...com,
Roger Quadros <rogerq@...nel.org>
Subject: Re: [PATCH 1/2] dt-bindings: soc: ti: pruss: Add clocks for ICSSG
On Fri, Nov 08, 2024 at 05:49:54PM +0530, Anwar, Md Danish wrote:
> Hi Krzysztof,
>
> On 11/7/2024 5:51 PM, Krzysztof Kozlowski wrote:
> > On 07/11/2024 12:58, MD Danish Anwar wrote:
> >>
> >>
> >> On 07/11/24 5:16 pm, MD Danish Anwar wrote:
> >>>
> >>>
> >>> On 07/11/24 5:14 pm, Krzysztof Kozlowski wrote:
> >>>> On 07/11/2024 12:36, MD Danish Anwar wrote:
> >>>>>
> >>>>>
> >>>>> On 07/11/24 5:01 pm, Krzysztof Kozlowski wrote:
> >>>>>> On 07/11/2024 11:45, MD Danish Anwar wrote:
> >>>>>>> Add clocks, assigned-clocks and assigned-clock-parents for ICSSG
> >>>>>>
> >>>>>> Why? We see what you are doing from the diff, no point to repeat it. I
> >>>>>> don't understand why you are doing it.
> >>>>>>
> >>>>>>>
> >>>>>>> Signed-off-by: MD Danish Anwar <danishanwar@...com>
> >>>>>>> ---
> >>>>>>> .../devicetree/bindings/soc/ti/ti,pruss.yaml | 11 +++++++++++
> >>>>>>> 1 file changed, 11 insertions(+)
> >>>>>>>
> >>>>>>> diff --git a/Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml b/Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml
> >>>>>>> index 3cb1471cc6b6..cf4c5884d8be 100644
> >>>>>>> --- a/Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml
> >>>>>>> +++ b/Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml
> >>>>>>> @@ -92,6 +92,17 @@ properties:
> >>>>>>> description: |
> >>>>>>> This property is as per sci-pm-domain.txt.
> >>>>>>>
> >>>>>>> + clocks:
> >>>>>>> + items:
> >>>>>>> + - description: ICSSG_CORE Clock
> >>>>>>> + - description: ICSSG_ICLK Clock
> >>>>>>> +
> >>>>>>> + assigned-clocks:
> >>>>>>> + maxItems: 1
> >>>>>>> +
> >>>>>>> + assigned-clock-parents:
> >>>>>>> + maxItems: 1
> >>>>>>
> >>>>>> Why? This is really not needed, so you need to explain why you are doing
> >>>>>> things differently than entire Linux kernel / DT bindings.
> >>>>>>
> >>>>>
> >>>>> I need to add this to the device tree node
> >>>>>
> >>>>> + clocks = <&k3_clks 81 0>, /* icssg0_core_clk */
> >>>>> + <&k3_clks 81 20>; /* icssg0_iclk */
> >>>>> + assigned-clocks = <&k3_clks 81 0>;
> >>>>> + assigned-clock-parents = <&k3_clks 81 2>;
> >>>>>
> >>>>> But without the above change in the binding I am getting below errors
> >>>>> while running dtbs check.
> >>>>>
> >>>>> /workdir/arch/arm64/boot/dts/ti/k3-am642-evm-nand.dtb: icssg@...00000:
> >>>>> 'assigned-clock-parents', 'assigned-clocks' do not match any of the
> >>>>> regexes: '^(pru|rtu|txpru)@[0-9a-f]+$', '^pa-stats@[a-f0-9]+$',
> >>>>> 'cfg@[a-f0-9]+$', 'iep@[a-f0-9]+$', 'interrupt-controller@[a-f0-9]+$',
> >>>>> 'mdio@[a-f0-9]+$', 'memories@[a-f0-9]+$', 'mii-g-rt@[a-f0-9]+$',
> >>>>> 'mii-rt@[a-f0-9]+$', 'pinctrl-[0-9]+'
> >>>>> +/workdir/arch/arm64/boot/dts/ti/k3-am642-evm-nand.dtb: icssg@...80000:
> >>>>> 'anyOf' conditional failed, one must be fixed:
> >>>>>
> >>>>> To fix this warning I added these in the binding and the warnings were
> >>>>> fixed.
> >>>>
> >>>> nah, cannot reproduce. Just be sure you work on recent kernel (last time
> >>>> you were sending it on some ancient stuff) and your packages are
> >>>> updated, including dt schema and other kernel dependencies.
> >>>>
>
> The purpose of this series is to add 'assigned-clock-parents',
> 'assigned-clocks' to the DT node. Initially I was only trying to add
> these two nodes to DT and at that time I got the above error. I also got
> the below error as well
So you pasted different error, not related to topic we discussed.
assigned-clock* depend on clocks. You must have clocks to assign them,
obviously. Device should no assign rates to clocks which are not its
inputs. :/
>
> /home/danish/workspace/linux-next/arch/arm64/boot/dts/ti/k3-am642-evm.dtb:
> icssg@...00000: 'anyOf' conditional failed, one must be fixed:
> 'clocks' is a required property
> '#clock-cells' is a required property
> from schema $id: http://devicetree.org/schemas/clock/clock.yaml#
>
>
> To fix this I added 'assigned-clock-parents', 'assigned-clocks' to the
> binding and at this time I got only the below error,
To fix this you must add clocks. The error tells you this.
So again: drop assigned properties. No error msg asked you to add them.
Best regards,
Krzysztof
Powered by blists - more mailing lists