linux-kernel - Re: [PATCH 3/3] tty: serial: atmel: make it selectable for ARCH

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2bf3bf7d-0360-4673-a7c7-4b74a9300f63@microchip.com>
Date: Fri, 8 Nov 2024 14:52:42 +0100
From: Nicolas Ferre <nicolas.ferre@...rochip.com>
To: Robert Marko <robert.marko@...tura.hr>
CC: <mturquette@...libre.com>, <sboyd@...nel.org>, <lee@...nel.org>,
	<gregkh@...uxfoundation.org>, <jirislaby@...nel.org>,
	<linux-clk@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<linux-serial@...r.kernel.org>, <linux-arm-kernel@...ts.infradead.org>,
	<luka.perkov@...tura.hr>
Subject: Re: [PATCH 3/3] tty: serial: atmel: make it selectable for
 ARCH_LAN969X

On 08/11/2024 at 14:40, Robert Marko wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> On Fri, Nov 8, 2024 at 2:25 PM Nicolas Ferre
> <nicolas.ferre@...rochip.com> wrote:
>>
>> On 08/11/2024 at 12:22, Robert Marko wrote:
>>
>> A little commit message would be better.
> 
> Hi Nicolas, I basically reused the same commit description as for MFD
> and else as all of the changes are
> basically the same.

Ok, I have certainly deleted it while replying. That's fine then.

>>> Signed-off-by: Robert Marko <robert.marko@...tura.hr>
>>> ---
>>>    drivers/tty/serial/Kconfig | 2 +-
>>>    1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig
>>> index 45f0f779fbf9..e6cf20b845f1 100644
>>> --- a/drivers/tty/serial/Kconfig
>>> +++ b/drivers/tty/serial/Kconfig
>>> @@ -128,7 +128,7 @@ config SERIAL_SB1250_DUART_CONSOLE
>>>    config SERIAL_ATMEL
>>>           bool "AT91 on-chip serial port support"
>>>           depends on COMMON_CLK
>>> -       depends on ARCH_AT91 || COMPILE_TEST
>>> +       depends on ARCH_AT91 || ARCH_LAN969X ||COMPILE_TEST
>>
>> Checkpatch.pl reports some "DOS line endings", you might need to fix this.
> 
> Hm, I ran checkpatch before sending in verbose mode and I dont see
> such a warning,
> my Sublime text is also set to Unix endings, I also just checked with
> cat -e and I dont see
> any DOS endings.

Ok, indeed. Probably my email client then. Sorry for the noise.

Regards,
   Nicolas

>>
>>>           select SERIAL_CORE
>>>           select SERIAL_MCTRL_GPIO if GPIOLIB
>>>           select MFD_AT91_USART
>>> --
>>> 2.47.0
>>
>>
>> Once fixed, you can add my:
>> Acked-by: Nicolas Ferre <nicolas.ferre@...rochip.com>
>>
>> Thanks, best regards,
>>     Nicolas
> 
> 
> 
> --
> Robert Marko
> Staff Embedded Linux Engineer
> Sartura d.d.
> Lendavska ulica 16a
> 10000 Zagreb, Croatia
> Email: robert.marko@...tura.hr
> Web: www.sartura.hr