linux-kernel - Re: [PATCH v2 0/3] Make Helped-by tag supported

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <28c0a0ecc2e2880e4cb98449767e2842@manjaro.org>
Date: Sat, 09 Nov 2024 04:10:11 +0100
From: Dragan Simic <dsimic@...jaro.org>
To: Dan Williams <dan.j.williams@...el.com>
Cc: Jonathan Corbet <corbet@....net>, apw@...onical.com, joe@...ches.com,
 dwaipayanray1@...il.com, lukas.bulwahn@...il.com, workflows@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-doc@...r.kernel.org, wens@...e.org
Subject: Re: [PATCH v2 0/3] Make Helped-by tag supported

Hello Dan,

On 2024-11-08 20:12, Dan Williams wrote:
> Dragan Simic wrote:
>> I'm fully aware that we may be reluctant to supporting additional 
>> tags,
>> because we may then end up with a whole bunch of strange tags that 
>> might
>> be a bit hard to understand and use properly, but I think that adding
>> Helped-by to the supported tag list may actually be a good thing to 
>> do.
>> As described above, Helped-by fits very well between the Suggested-by
>> tag and the Co-developed-by + Signed-off-by pair of tags, and I think
>> that providing the right level of attribution may be beneficial.
> 
> Patch attribution is separate from giving thanks. I would much rather
> someone take the time to say "Thanks" in the changelog with some
> supporting text rather than boil down all the myriad ways to be 
> thankful
> into a generic tag. "git log --grep=Thanks" often yields valuable
> details, beyond just attribution, on how people have helped each other
> develop this global project of ours. If the introduction of Helped-by
> would replace even one authentic "Thank you" note with a generic tag
> then it is a net loss for the community.

I do agree that writing "Thanks John for helping with..." in a patch
description would be nice, but unfortunately I've seen multiple times
that people don't enjoy writing their patch descriptions at all, and
just want to "get them out the door" as quickly as possible.

With that in mind, making Helped-by tags supported would allow such
people to at least quickly mention someone they're thankful to, which
actually wouldn't prevent anyone from saying the same more verbosely
in a patch description.