linux-kernel - Re: [PATCH] net: netronome: use double ptr for gstrings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20241108195941.7d45c6e3@kernel.org>
Date: Fri, 8 Nov 2024 19:59:41 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Rosen Penev <rosenp@...il.com>
Cc: netdev@...r.kernel.org, Louis Peens <louis.peens@...igine.com>, Andrew
 Lunn <andrew+netdev@...n.ch>, "David S. Miller" <davem@...emloft.net>, Eric
 Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>,
 oss-drivers@...igine.com (open list:NETRONOME ETHERNET DRIVERS),
 linux-kernel@...r.kernel.org (open list)
Subject: Re: [PATCH] net: netronome: use double ptr for gstrings

On Fri,  8 Nov 2024 12:41:54 -0800 Rosen Penev wrote:
> Currently the code copies a pointer and propagates increments that way.
> 
> Instead of doing that, increment with a double pointer, which the
> ethtool string helpers expect.
> 
> Also converted some memcpy calls to ethtool_puts, as they should be.

Let's not "convert" a driver which already uses the ethtool_ print
helpers. Replace the memcpy but leave the rest be, please.
-- 
pw-bot: cr