linux-kernel - Re: [PATCH v5 6/7] rust: Add read_poll

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20241109.141520.1319530714927998446.fujita.tomonori@gmail.com>
Date: Sat, 09 Nov 2024 14:15:20 +0900 (JST)
From: FUJITA Tomonori <fujita.tomonori@...il.com>
To: boqun.feng@...il.com
Cc: fujita.tomonori@...il.com, anna-maria@...utronix.de,
 frederic@...nel.org, tglx@...utronix.de, jstultz@...gle.com,
 sboyd@...nel.org, linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
 rust-for-linux@...r.kernel.org, andrew@...n.ch, hkallweit1@...il.com,
 tmgross@...ch.edu, ojeda@...nel.org, alex.gaynor@...il.com,
 gary@...yguo.net, bjorn3_gh@...tonmail.com, benno.lossin@...ton.me,
 a.hindborg@...sung.com, aliceryhl@...gle.com, arnd@...db.de
Subject: Re: [PATCH v5 6/7] rust: Add read_poll_timeout functions

On Wed, 6 Nov 2024 10:18:03 -0800
Boqun Feng <boqun.feng@...il.com> wrote:

> On Fri, Nov 01, 2024 at 10:01:20AM +0900, FUJITA Tomonori wrote:
> [...]
>> @@ -44,6 +45,7 @@
>>  pub mod page;
>>  pub mod prelude;
>>  pub mod print;
>> +pub mod processor;
>>  pub mod sizes;
>>  pub mod rbtree;
>>  mod static_assert;
>> diff --git a/rust/kernel/processor.rs b/rust/kernel/processor.rs
>> new file mode 100644
>> index 000000000000..eeeff4be84fa
>> --- /dev/null
>> +++ b/rust/kernel/processor.rs
> 
> What else would we put into this file? `smp_processor_id()` and IPI
> functionality?

Yeah, we would need smp_processor_id() but not sure about the other
functions. There aren't many processor-related functions that Rust
drivers directly need to call, I guess.

> If so, I would probably want to rename this to cpu.rs.

Fine by me, I'll go with cpu.rs in the next version.

I chose processor.rs just because the C side uses processor.h for
cpu_relax() but cpu.rs also looks good.