[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <20241109091748.4037589-1-zhangheng@kylinos.cn>
Date: Sat, 9 Nov 2024 17:17:48 +0800
From: zhangheng <zhangheng@...inos.cn>
To: marcel@...tmann.org,
johan.hedberg@...il.com,
luiz.dentz@...il.com,
erick.archer@...look.com,
kees@...nel.org,
geert@...ux-m68k.org,
jirislaby@...nel.org
Cc: linux-bluetooth@...r.kernel.org,
linux-kernel@...r.kernel.org,
zhangheng <zhangheng@...inos.cn>
Subject: [PATCH 1/4] tty: rfcomm: use sysfs_emit() instead of sprintf()
Follow the advice in Documentation/filesystems/sysfs.rst:
show() should only use sysfs_emit() or sysfs_emit_at() when formatting
the value to be returned to user space.
Signed-off-by: zhangheng <zhangheng@...inos.cn>
---
net/bluetooth/rfcomm/tty.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/bluetooth/rfcomm/tty.c b/net/bluetooth/rfcomm/tty.c
index af80d599c337..21a5b5535ebc 100644
--- a/net/bluetooth/rfcomm/tty.c
+++ b/net/bluetooth/rfcomm/tty.c
@@ -201,14 +201,14 @@ static ssize_t address_show(struct device *tty_dev,
struct device_attribute *attr, char *buf)
{
struct rfcomm_dev *dev = dev_get_drvdata(tty_dev);
- return sprintf(buf, "%pMR\n", &dev->dst);
+ return sysfs_emit(buf, "%pMR\n", &dev->dst);
}
static ssize_t channel_show(struct device *tty_dev,
struct device_attribute *attr, char *buf)
{
struct rfcomm_dev *dev = dev_get_drvdata(tty_dev);
- return sprintf(buf, "%d\n", dev->channel);
+ return sysfs_emit(buf, "%d\n", dev->channel);
}
static DEVICE_ATTR_RO(address);
--
2.45.2
Powered by blists - more mailing lists