linux-kernel - Re: [PATCH RFC v3 4/4] module: refactor ro_after

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5f1cdf77-b6fc-4a1d-9b6f-a578e1c50dd9@csgroup.eu>
Date: Sat, 9 Nov 2024 10:49:28 +0100
From: Christophe Leroy <christophe.leroy@...roup.eu>
To: da.gomez@...sung.com, Luis Chamberlain <mcgrof@...nel.org>,
 Petr Pavlu <petr.pavlu@...e.com>, Sami Tolvanen <samitolvanen@...gle.com>,
 Thomas Gleixner <tglx@...utronix.de>, Jinjie Ruan <ruanjinjie@...wei.com>,
 Jens Axboe <axboe@...nel.dk>
Cc: "Daniel Gomez (Samsung)" <d+samsung@...ces.com>,
 linux-modules@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH RFC v3 4/4] module: refactor ro_after_init failure path



Le 08/11/2024 à 17:12, Daniel Gomez via B4 Relay a écrit :
> [Vous ne recevez pas souvent de courriers de devnull+da.gomez.samsung.com@...nel.org. Découvrez pourquoi ceci est important à https://aka.ms/LearnAboutSenderIdentification ]
> 
> From: Daniel Gomez <da.gomez@...sung.com>
> 
> When ro_after_init fails, we need to unload the module.
> 
> Rename the goto tag to fail_ro_after_init to make it more clear and try
> to check for dependencies, stop the module and call the exit function.
> This allows to unload the module if ro_after_init fails.

Doesn't build:

   CC      kernel/module/main.o
kernel/module/main.c: In function 'do_init_module':
kernel/module/main.c:2626:19: error: 'struct module' has no member named 
'source_list'; did you mean 'bug_list'?
   list_empty(&mod->source_list);
                    ^~~~~~~~~~~
                    bug_list
kernel/module/main.c:2627:2: error: implicit declaration of function 
'try_stop_module'; did you mean 'do_init_module'? 
[-Werror=implicit-function-declaration]
   try_stop_module(mod, 0, &forced);
   ^~~~~~~~~~~~~~~
   do_init_module
kernel/module/main.c:2629:11: error: 'struct module' has no member named 
'exit'; did you mean 'init'?
   if (mod->exit != NULL)
            ^~~~
            init
kernel/module/main.c:2630:8: error: 'struct module' has no member named 
'exit'; did you mean 'init'?
    mod->exit();
         ^~~~
         init



Christophe