linux-kernel - Re: [PATCH net-next 2/2] net: ethernet: ti: am65-cpsw: enable DSCP to priority map for RX

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <73f8d7a9-59ef-4d54-a024-4cf99d60abc0@kernel.org>
Date: Sat, 9 Nov 2024 12:31:24 +0200
From: Roger Quadros <rogerq@...nel.org>
To: Siddharth Vadapalli <s-vadapalli@...com>
Cc: Andrew Lunn <andrew+netdev@...n.ch>, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 Simon Horman <horms@...nel.org>, linux-omap@...r.kernel.org,
 netdev@...r.kernel.org, linux-kernel@...r.kernel.org, srk@...com,
 Pekka Varis <p-varis@...com>
Subject: Re: [PATCH net-next 2/2] net: ethernet: ti: am65-cpsw: enable DSCP to
 priority map for RX

On 08/11/2024 16:42, Siddharth Vadapalli wrote:
> On Fri, Nov 08, 2024 at 02:55:18PM +0200, Roger Quadros wrote:
>> Hi Siddharth,
>>
>> On 08/11/2024 14:30, Siddharth Vadapalli wrote:
> 
> [...]
> 
>>>> +#define AM65_CPSW_PORTN_REG_CTL			0x004
>>>
>>> nitpick: indentation needs to be fixed here to align with the macros
>>> below.
>>
>> It is fine in the code and in my editor in this reply email.
> 
> That's strange. But it appears the same to me as seen at:
> https://lore.kernel.org/r/20241105-am65-cpsw-multi-rx-dscp-v1-2-38db85333c88@kernel.org/
> where the indentation looks incorrect.

It is probably editor specific. There are in fact 3 tab spaces to align it
with the number.

Can you please apply the patch and see if it is OK in the code?

-- 
cheers,
-roger