linux-kernel - Re: [PATCH net-next v9 5/6] selftests: net: Add busy_poll

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <672f7aa6accf5_3564c0294e3@willemb.c.googlers.com.notmuch>
Date: Sat, 09 Nov 2024 10:07:18 -0500
From: Willem de Bruijn <willemdebruijn.kernel@...il.com>
To: Joe Damato <jdamato@...tly.com>, 
 netdev@...r.kernel.org
Cc: corbet@....net, 
 hdanton@...a.com, 
 bagasdotme@...il.com, 
 pabeni@...hat.com, 
 namangulati@...gle.com, 
 edumazet@...gle.com, 
 amritha.nambiar@...el.com, 
 sridhar.samudrala@...el.com, 
 sdf@...ichev.me, 
 peter@...eblog.net, 
 m2shafiei@...terloo.ca, 
 bjorn@...osinc.com, 
 hch@...radead.org, 
 willy@...radead.org, 
 willemdebruijn.kernel@...il.com, 
 skhawaja@...gle.com, 
 kuba@...nel.org, 
 Joe Damato <jdamato@...tly.com>, 
 Martin Karsten <mkarsten@...terloo.ca>, 
 "David S. Miller" <davem@...emloft.net>, 
 Simon Horman <horms@...nel.org>, 
 Shuah Khan <shuah@...nel.org>, 
 linux-kernel@...r.kernel.org (open list), 
 linux-kselftest@...r.kernel.org (open list:KERNEL SELFTEST FRAMEWORK)
Subject: Re: [PATCH net-next v9 5/6] selftests: net: Add busy_poll_test

Joe Damato wrote:
> Add an epoll busy poll test using netdevsim.
> 
> This test is comprised of:
>   - busy_poller (via busy_poller.c)
>   - busy_poll_test.sh which loads netdevsim, sets up network namespaces,
>     and runs busy_poller to receive data and socat to send data.
> 
> The selftest tests two different scenarios:
>   - busy poll (the pre-existing version in the kernel)
>   - busy poll with suspend enabled (what this series adds)
> 
> The data transmit is a 1MiB temporary file generated from /dev/urandom
> and the test is considered passing if the md5sum of the input file to
> socat matches the md5sum of the output file from busy_poller.
> 
> netdevsim was chosen instead of veth due to netdevsim's support for
> netdev-genl.
> 
> For now, this test uses the functionality that netdevsim provides. In the
> future, perhaps netdevsim can be extended to emulate device IRQs to more
> thoroughly test all pre-existing kernel options (like defer_hard_irqs)
> and suspend.
> 
> Signed-off-by: Joe Damato <jdamato@...tly.com>
> Co-developed-by: Martin Karsten <mkarsten@...terloo.ca>
> Signed-off-by: Martin Karsten <mkarsten@...terloo.ca>
> Acked-by: Stanislav Fomichev <sdf@...ichev.me>

Reviewed-by: Willem de Bruijn <willemb@...gle.com>

minor nit that ULONG_MAX can not be true with uint32_t on 64-bit
platforms. Definitely no need to respin just for that.