linux-kernel - Re: [PATCH v2 3/4] hwmon: tmp108: Add support for I3C device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241109151531.37ac4226@jic23-huawei>
Date: Sat, 9 Nov 2024 15:15:31 +0000
From: Jonathan Cameron <jic23@...nel.org>
To: Guenter Roeck <linux@...ck-us.net>
Cc: Frank Li <Frank.Li@....com>, Rob Herring <robh@...nel.org>, Krzysztof
 Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>,
 Lars-Peter Clausen <lars@...afoo.de>, Shawn Guo <shawnguo@...nel.org>,
 Sascha Hauer <s.hauer@...gutronix.de>, Pengutronix Kernel Team
 <kernel@...gutronix.de>, Fabio Estevam <festevam@...il.com>, Jean Delvare
 <jdelvare@...e.com>, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-iio@...r.kernel.org,
 imx@...ts.linux.dev, linux-arm-kernel@...ts.infradead.org, Krzysztof
 Kozlowski <krzk@...nel.org>, linux-hwmon@...r.kernel.org
Subject: Re: [PATCH v2 3/4] hwmon: tmp108: Add support for I3C device

On Sat, 9 Nov 2024 06:53:28 -0800
Guenter Roeck <linux@...ck-us.net> wrote:

> On 11/9/24 05:16, Jonathan Cameron wrote:
> > On Fri, 08 Nov 2024 17:26:57 -0500
> > Frank Li <Frank.Li@....com> wrote:
> >   
> >> Add support for I3C device in the tmp108 driver to handle the P3T1085
> >> sensor. Register the I3C device driver to enable I3C functionality for the
> >> sensor.
> >>
> >> Signed-off-by: Frank Li <Frank.Li@....com>
> >> ---
> >>   drivers/hwmon/tmp108.c | 31 +++++++++++++++++++++++++++++++
> >>   1 file changed, 31 insertions(+)
> >>
> >> diff --git a/drivers/hwmon/tmp108.c b/drivers/hwmon/tmp108.c
> >> index bfbea6349a95f..83d6847cb542c 100644
> >> --- a/drivers/hwmon/tmp108.c
> >> +++ b/drivers/hwmon/tmp108.c
> >> @@ -13,6 +13,8 @@
> >>   #include <linux/mutex.h>
> >>   #include <linux/of.h>
> >>   #include <linux/i2c.h>
> >> +#include <linux/i3c/device.h>
> >> +#include <linux/i3c/master.h>  
> > 
> > Seems odd you need master.h in a device driver.
> > I'll guess that's because you should be using i3cdev_to_device()  
> 
> I assume you mean i3cdev_to_dev() ?
> 
Indeed! :(

> Good point, but there are not many examples to draw from. The one
> existing iio driver (st_lsm6dsx) doesn't use it either. I'll send
> a patch shortly to fix that to prevent others from making the same
> mistake.
Excellent.
> 
> Thanks,
> Guenter
>