linux-kernel - Re: [PATCH] iio: dac: mcp4725: Use of_property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20241109152019.7eb9051e@jic23-huawei>
Date: Sat, 9 Nov 2024 15:20:19 +0000
From: Jonathan Cameron <jic23@...nel.org>
To: "Rob Herring (Arm)" <robh@...nel.org>
Cc: Lars-Peter Clausen <lars@...afoo.de>, linux-iio@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] iio: dac: mcp4725: Use of_property_present() for
 non-boolean properties

On Mon,  4 Nov 2024 13:08:46 -0600
"Rob Herring (Arm)" <robh@...nel.org> wrote:

> The use of of_property_read_bool() for non-boolean properties is
> deprecated in favor of of_property_present() when testing for property
> presence.
> 
> Signed-off-by: Rob Herring (Arm) <robh@...nel.org>
Applied to the testing branch of iio.git. I'll rebase that on 6.13-rc1
once available and push out for linux-next to pick up.

thanks,

Jonathan

> ---
>  drivers/iio/dac/mcp4725.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/dac/mcp4725.c b/drivers/iio/dac/mcp4725.c
> index 25bb1c0490af..1337fb02ccf5 100644
> --- a/drivers/iio/dac/mcp4725.c
> +++ b/drivers/iio/dac/mcp4725.c
> @@ -379,7 +379,7 @@ static int mcp4725_probe_dt(struct device *dev,
>  			    struct mcp4725_platform_data *pdata)
>  {
>  	/* check if is the vref-supply defined */
> -	pdata->use_vref = device_property_read_bool(dev, "vref-supply");
> +	pdata->use_vref = device_property_present(dev, "vref-supply");
>  	pdata->vref_buffered =
>  		device_property_read_bool(dev, "microchip,vref-buffered");
>