linux-kernel - Re: [PATCH v2] sched_ext: add a missing rcu_read_lock/unlock pair at scx_select_cpu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Zy-EMnJzWpS1K83R@slm.duckdns.org>
Date: Sat, 9 Nov 2024 05:48:02 -1000
From: Tejun Heo <tj@...nel.org>
To: Changwoo Min <multics69@...il.com>
Cc: void@...ifault.com, changwoo@...lia.com, kernel-dev@...lia.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] sched_ext: add a missing rcu_read_lock/unlock pair at
 scx_select_cpu_dfl()

On Sat, Nov 09, 2024 at 03:29:05PM +0900, Changwoo Min wrote:
> When getting an LLC CPU mask in the default CPU selection policy,
> scx_select_cpu_dfl(), a pointer to the sched_domain is dereferenced
> using rcu_read_lock() without holding rcu_read_lock(). Such an unprotected
> dereference often causes the following warning and can cause an invalid
> memory access in the worst case.
> 
> Therefore, protect dereference of a sched_domain pointer using a pair
> of rcu_read_lock() and unlock().
...
> Signed-off-by: Changwoo Min <changwoo@...lia.com>

Applied to sched_ext/for-6.13.

Thanks.

-- 
tejun